From: "Arinzon, David" <darinzon@amazon.com>
To: Joe Damato <jdamato@fastly.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "Agroskin, Shay" <shayagr@amazon.com>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Dagan, Noam" <ndagan@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kamal Heib <kheib@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: RE: [net-next v2 2/2] ena: Link queues to NAPIs
Date: Wed, 2 Oct 2024 06:28:18 +0000 [thread overview]
Message-ID: <10bc83e9df17408a9f0dd7a56abc9dc1@amazon.com> (raw)
In-Reply-To: <20241002001331.65444-3-jdamato@fastly.com>
> Link queues to NAPIs using the netdev-genl API so this information is
> queryable.
>
> $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
> --dump queue-get --json='{"ifindex": 2}'
>
> [{'id': 0, 'ifindex': 2, 'napi-id': 8201, 'type': 'rx'},
> {'id': 1, 'ifindex': 2, 'napi-id': 8202, 'type': 'rx'},
> {'id': 2, 'ifindex': 2, 'napi-id': 8203, 'type': 'rx'},
> {'id': 3, 'ifindex': 2, 'napi-id': 8204, 'type': 'rx'},
> {'id': 4, 'ifindex': 2, 'napi-id': 8205, 'type': 'rx'},
> {'id': 5, 'ifindex': 2, 'napi-id': 8206, 'type': 'rx'},
> {'id': 6, 'ifindex': 2, 'napi-id': 8207, 'type': 'rx'},
> {'id': 7, 'ifindex': 2, 'napi-id': 8208, 'type': 'rx'},
> {'id': 0, 'ifindex': 2, 'napi-id': 8201, 'type': 'tx'},
> {'id': 1, 'ifindex': 2, 'napi-id': 8202, 'type': 'tx'},
> {'id': 2, 'ifindex': 2, 'napi-id': 8203, 'type': 'tx'},
> {'id': 3, 'ifindex': 2, 'napi-id': 8204, 'type': 'tx'},
> {'id': 4, 'ifindex': 2, 'napi-id': 8205, 'type': 'tx'},
> {'id': 5, 'ifindex': 2, 'napi-id': 8206, 'type': 'tx'},
> {'id': 6, 'ifindex': 2, 'napi-id': 8207, 'type': 'tx'},
> {'id': 7, 'ifindex': 2, 'napi-id': 8208, 'type': 'tx'}]
>
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> ---
> v2:
> - Comments added to ena_napi_disable_in_range and
> ena_napi_enable_in_range
> - No functional changes
>
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 28
> +++++++++++++++++---
> 1 file changed, 24 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 74ce9fa45cf8..96df20854eb9 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -1821,20 +1821,40 @@ static void ena_napi_disable_in_range(struct
> ena_adapter *adapter,
> int first_index,
> int count) {
> + struct napi_struct *napi;
> int i;
>
> - for (i = first_index; i < first_index + count; i++)
> - napi_disable(&adapter->ena_napi[i].napi);
> + for (i = first_index; i < first_index + count; i++) {
> + napi = &adapter->ena_napi[i].napi;
> + if (!ENA_IS_XDP_INDEX(adapter, i)) {
> + /* This API is supported for non-XDP queues only */
> + netif_queue_set_napi(adapter->netdev, i,
> + NETDEV_QUEUE_TYPE_TX, NULL);
> + netif_queue_set_napi(adapter->netdev, i,
> + NETDEV_QUEUE_TYPE_RX, NULL);
> + }
> + napi_disable(napi);
> + }
> }
>
> static void ena_napi_enable_in_range(struct ena_adapter *adapter,
> int first_index,
> int count) {
> + struct napi_struct *napi;
> int i;
>
> - for (i = first_index; i < first_index + count; i++)
> - napi_enable(&adapter->ena_napi[i].napi);
> + for (i = first_index; i < first_index + count; i++) {
> + napi = &adapter->ena_napi[i].napi;
> + napi_enable(napi);
> + if (!ENA_IS_XDP_INDEX(adapter, i)) {
> + /* This API is supported for non-XDP queues only */
> + netif_queue_set_napi(adapter->netdev, i,
> + NETDEV_QUEUE_TYPE_RX, napi);
> + netif_queue_set_napi(adapter->netdev, i,
> + NETDEV_QUEUE_TYPE_TX, napi);
> + }
> + }
> }
>
> /* Configure the Rx forwarding */
> --
> 2.25.1
LGTM
Reviewed-by: David Arinzon <darinzon@amazon.com>
next prev parent reply other threads:[~2024-10-02 6:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 0:13 [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances Joe Damato
2024-10-02 0:13 ` [net-next v2 1/2] ena: Link IRQs to " Joe Damato
2024-10-02 6:27 ` Arinzon, David
2024-10-02 0:13 ` [net-next v2 2/2] ena: Link queues to NAPIs Joe Damato
2024-10-02 6:28 ` Arinzon, David [this message]
2024-10-02 6:28 ` [net-next v2 0/2] ena: Link IRQs, queues, and NAPI instances Arinzon, David
2024-10-03 23:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10bc83e9df17408a9f0dd7a56abc9dc1@amazon.com \
--to=darinzon@amazon.com \
--cc=akiyano@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdamato@fastly.com \
--cc=kheib@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ndagan@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedb@amazon.com \
--cc=shayagr@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.