From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43730) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eqa6r-0006em-SX for qemu-devel@nongnu.org; Tue, 27 Feb 2018 02:55:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eqa6r-0007aQ-8U for qemu-devel@nongnu.org; Tue, 27 Feb 2018 02:55:37 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35218 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eqa6r-0007aG-3d for qemu-devel@nongnu.org; Tue, 27 Feb 2018 02:55:37 -0500 References: <1519290253-23854-1-git-send-email-thuth@redhat.com> From: Jason Wang Message-ID: <10bec09b-eead-8a2a-aff3-f42e914da451@redhat.com> Date: Tue, 27 Feb 2018 15:55:32 +0800 MIME-Version: 1.0 In-Reply-To: <1519290253-23854-1-git-send-email-thuth@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] net: Move the toeplitz functions from checksum.h to net_rx_pkt.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org, Dmitry Fleytman On 2018=E5=B9=B402=E6=9C=8822=E6=97=A5 17:04, Thomas Huth wrote: > The functions are only used in this single .c file, so there is > no need to put all this code in a header that is included from > multiple places. > > Signed-off-by: Thomas Huth > --- > hw/net/net_rx_pkt.c | 44 +++++++++++++++++++++++++++++++++++++++++= +++ > include/net/checksum.h | 44 -----------------------------------------= --- > 2 files changed, 44 insertions(+), 44 deletions(-) Hi Thomas, We have plan to implement RSS for virtio-net, so it looks like we'd=20 better keep it in the header. Thanks