All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Hannes Reinecke <hare@suse.de>,
	"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, John Garry <john.g.garry@oracle.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>
Subject: Re: [PATCH v2 2/2] scsi: core: Eliminate scsi_log_{reserve,release}_buffer()
Date: Wed, 9 Sep 2026 09:37:16 -0700	[thread overview]
Message-ID: <10c53a10-e553-4aef-8438-2ad1dbfc8993@acm.org> (raw)
In-Reply-To: <f53edf7b-fc80-4815-a884-f03a25ab0527@suse.de>

On 9/7/26 7:44 AM, Hannes Reinecke wrote:
> But that would completely revert the idea of this patch; 'dev_printk' 
> will always insert a newline after the string argument, and the whole 
> point of this patch was that do _not_ want to have a newline here as we
> want to print out several things before terminating the log message.

KERN_CONT should be avoided whenever possible because it causes log
lines to be mixed up if a context switch happens in the middle of
multiple printk() statements that use KERN_CONT. Do you perhaps want me
to include patches that eliminate the use of KERN_CONT from SCSI code
(NCR5380, aic7xxx, ch, mac53c94, megaraid, qla1280 and sd)?

Thanks,

Bart.

  reply	other threads:[~2026-09-09 16:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 17:58 [PATCH v2 0/2] scsi: core: Optimize the SCSI printk() variants Bart Van Assche
2026-08-31 17:58 ` [PATCH v2 1/2] scsi: core: Add KUnit tests for scsi_logging.c Bart Van Assche
2026-08-31 20:05   ` sashiko-bot
2026-08-31 17:58 ` [PATCH v2 2/2] scsi: core: Eliminate scsi_log_{reserve,release}_buffer() Bart Van Assche
2026-09-07 14:44   ` Hannes Reinecke
2026-09-09 16:37     ` Bart Van Assche [this message]
2026-09-10 10:45       ` Hannes Reinecke
2026-09-10 13:28         ` Bart Van Assche
2026-09-10  3:50     ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10c53a10-e553-4aef-8438-2ad1dbfc8993@acm.org \
    --to=bvanassche@acm.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=hare@suse.de \
    --cc=john.g.garry@oracle.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mkp@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.