From: Sven Eckelmann <sven@narfation.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [PATCH 3/3] batman-adv: forward broadcast packets via unicast transmissions
Date: Sat, 25 May 2019 12:21:11 +0200 [thread overview]
Message-ID: <11000634.v2cH04sJFL@sven-edge> (raw)
In-Reply-To: <20190514073859.2053-4-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]
On Tuesday, 14 May 2019 09:38:59 CEST Linus Lüssing wrote:
> +static bool batadv_forw_bcast_may_ucast(struct batadv_priv *bat_priv,
> + struct batadv_hard_iface *if_out)
> +{
> + unsigned long num_direct_orig;
> + unsigned long num_bcast_no_urcv;
> +
> + num_direct_orig = atomic_read(&if_out->num_direct_orig);
> + num_bcast_no_urcv = atomic_read(&if_out->num_bcast_no_urcv);
> +
> + return !num_bcast_no_urcv &&
> + (num_direct_orig <= atomic_read(&bat_priv->multicast_fanout));
> +}
ecsv/pu|sparse linux-3.16.66 cfg: BLA=y DAT=y DEBUGFS=n DEBUG=y TRACING=y NC=n MCAST=n BATMAN_V=y SYSFS=y|/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:928:57: error: no member 'multicast_fanout' in struct batadv_priv
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:928:47: warning: call with no type!
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c: In function ‘batadv_forw_bcast_may_ucast’:
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:928:50: error: ‘struct batadv_priv’ has no member named ‘multicast_fanout’
(num_direct_orig <= atomic_read(&bat_priv->multicast_fanout));
^~
/home/build_test/build_env/tmp.I4uiDZgE1M/net/batman-adv/send.c:929:1: warning: control reaches end of non-void function [-Wreturn-type]
}
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-05-25 10:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 7:38 [PATCH 0/3] batman-adv: broadcast flooding improvements Linus Lüssing
2019-05-14 7:38 ` [PATCH 1/3] batman-adv: bcast: queue per interface, if needed Linus Lüssing
2019-05-25 10:21 ` Sven Eckelmann
2019-05-14 7:38 ` [PATCH 2/3] batman-adv: allow broadcast packet type with unicast destination Linus Lüssing
2019-05-25 10:02 ` Sven Eckelmann
2019-05-25 10:24 ` Sven Eckelmann
2019-05-25 10:53 ` Sven Eckelmann
2019-05-14 7:38 ` [PATCH 3/3] batman-adv: forward broadcast packets via unicast transmissions Linus Lüssing
2019-05-25 10:21 ` Sven Eckelmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11000634.v2cH04sJFL@sven-edge \
--to=sven@narfation.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.