All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Revell <rlrevell@joe-job.com>
To: alsa-devel <alsa-devel@lists.sourceforge.net>
Cc: Takashi Iwai <tiwai@suse.de>,
	James Courtier-Dutton <James@superbug.co.uk>
Subject: [PATCH] display EFGH sends in proc file for audigy
Date: Wed, 17 Nov 2004 14:17:48 -0500	[thread overview]
Message-ID: <1100719069.6930.38.camel@krustophenia.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Currently we only display the first four sends even on the Audigy which
has 8 sends.  This obscures the fact that we set sends EFGH all to zero
by default which is technically illegal.  (Though it seems to work, the
kX Windows driver sets these last 4 sends to high channels (62-24) and
never sets two sends to the same address as the header file instructs).

This patch adds display of sends EFGH in the /proc file.

Signed-Off-By: Lee Revell <rlrevell@joe-job.com>



[-- Attachment #2: Type: text/x-patch, Size: 1389 bytes --]

Index: alsa/alsa-kernel/pci/emu10k1/emuproc.c
===================================================================
RCS file: /cvsroot/alsa/alsa-kernel/pci/emu10k1/emuproc.c,v
retrieving revision 1.21
diff -u -r1.21 emuproc.c
--- alsa/alsa-kernel/pci/emu10k1/emuproc.c	6 Sep 2004 15:05:19 -0000	1.21
+++ alsa/alsa-kernel/pci/emu10k1/emuproc.c	17 Nov 2004 19:11:50 -0000
@@ -175,7 +175,7 @@
 	};
 
 	emu10k1_t *emu = entry->private_data;
-	unsigned int val;
+	unsigned int val, val1;
 	int nefx = emu->audigy ? 64 : 32;
 	char **outputs = emu->audigy ? audigy_outs : creative_outs;
 	int idx;
@@ -184,6 +184,8 @@
 	val = emu->audigy ?
 		snd_emu10k1_ptr_read(emu, A_FXRT1, 0) :
 		snd_emu10k1_ptr_read(emu, FXRT, 0);
+	if (emu->audigy)
+		val2 = snd_emu10k1_ptr_read(emu, A_FXRT2, 0);
 	snd_iprintf(buffer, "Card                  : %s\n",
 		    emu->audigy ? "Audigy" : (emu->APS ? "EMU APS" : "Creative"));
 	snd_iprintf(buffer, "Internal TRAM (words) : 0x%x\n", emu->fx8010.itram_size);
@@ -195,6 +197,11 @@
 			    (val >> 8) & 0x3f,
 			    (val >> 16) & 0x3f,
 			    (val >> 24) & 0x3f);
+		snd_iprintf(buffer, "Effect Send Routing   : E=%i, F=%i, G=%i, H=%i\n",
+			    val1 & 0x3f,
+			    (val1 >> 8) & 0x3f,
+			    (val1 >> 16) & 0x3f,
+			    (val1 >> 24) & 0x3f);
 	} else {
 		snd_iprintf(buffer, "Effect Send Routing   : A=%i, B=%i, C=%i, D=%i\n",
 			    (val >> 16) & 0x0f,

             reply	other threads:[~2004-11-17 19:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-17 19:17 Lee Revell [this message]
2004-11-17 23:48 ` [PATCH] display EFGH sends in proc file for audigy Lee Revell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1100719069.6930.38.camel@krustophenia.net \
    --to=rlrevell@joe-job.com \
    --cc=James@superbug.co.uk \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.