Re: [PATCH] gdth buggy page mapping

[James Bottomley <James.Bottomley@SteelEye.com>]

Actually, this:

On Tue, 2004-11-23 at 12:06, Jens Axboe wrote:
> @@ -2717,8 +2716,8 @@
>      if (scp->use_sg) {
>          sl = (struct scatterlist *)scp->request_buffer;
>  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,4,13)
> -        sgcnt = pci_map_sg(ha->pdev,sl,scp->use_sg,PCI_DMA_FROMDEVICE);
> -        for (i=0,cpsum=0; i<sgcnt; ++i,++sl) {
> +        for (i=0,cpsum=0; i<scp->use_sg; ++i,++sl) {
> +	    unsigned long flags;
>              cpnow = (ushort)sg_dma_len(sl);

Won't quite work any more.  On most platforms, it will since
sg_dma_len(sl) expands to sl->length which is the correct thing. 
However, on some, like parisc, x86_64, ppc64 it will expand to a
different parameter which won't get filled in if the dma mapping is
never done.  I think all use of the sg_dma_ macros in this driver will
need modifying with this change.

James