From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [2.6 patch] sstfb.c: make some code static Date: Wed, 24 Nov 2004 22:49:47 +0000 Message-ID: <1101336587.2571.1.camel@localhost.localdomain> References: <20041121153646.GA2829@stusta.de> Reply-To: linux-fbdev-devel@lists.sourceforge.net Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Exim 4.30) id 1CXLW7-0000Uk-3J for linux-fbdev-devel@lists.sourceforge.net; Thu, 25 Nov 2004 07:26:43 -0800 Received: from [81.2.110.250] (helo=localhost.localdomain) by sc8-sf-mx1.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.41) id 1CXLW4-0001bE-UI for linux-fbdev-devel@lists.sourceforge.net; Thu, 25 Nov 2004 07:26:42 -0800 In-Reply-To: <20041121153646.GA2829@stusta.de> Sender: linux-fbdev-devel-admin@lists.sourceforge.net Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: List-Post: List-Help: List-Subscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Adrian Bunk Cc: Ghozlane Toumi , Antonino Daplas , Linux Kernel Mailing List , linux-fbdev-devel@lists.sourceforge.net On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote: > The patch below makes some needlessly global code static. No it doesn't. It makes some functions static (which is fine) and adds some nasty messy pointless #ifdefs. It touches no variable at all. Please check your description texts and also don't fill the kernel with ifdef crap. Probably the __setup stuff should be a module param new style too. ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://productguide.itmanagersjournal.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263068AbUK0ACD (ORCPT ); Fri, 26 Nov 2004 19:02:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263096AbUK0ABZ (ORCPT ); Fri, 26 Nov 2004 19:01:25 -0500 Received: from zeus.kernel.org ([204.152.189.113]:9413 "EHLO zeus.kernel.org") by vger.kernel.org with ESMTP id S263068AbUKZTl0 (ORCPT ); Fri, 26 Nov 2004 14:41:26 -0500 Subject: Re: [2.6 patch] sstfb.c: make some code static From: Alan Cox To: Adrian Bunk Cc: Ghozlane Toumi , Antonino Daplas , Linux Kernel Mailing List , linux-fbdev-devel@lists.sourceforge.net In-Reply-To: <20041121153646.GA2829@stusta.de> References: <20041121153646.GA2829@stusta.de> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1101336587.2571.1.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 (1.4.6-2) Date: Wed, 24 Nov 2004 22:49:47 +0000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sul, 2004-11-21 at 15:36, Adrian Bunk wrote: > The patch below makes some needlessly global code static. No it doesn't. It makes some functions static (which is fine) and adds some nasty messy pointless #ifdefs. It touches no variable at all. Please check your description texts and also don't fill the kernel with ifdef crap. Probably the __setup stuff should be a module param new style too.