From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Fbdev development list <linux-fbdev-devel@lists.sourceforge.net>
Cc: "Antonino A. Daplas" <adaplas@hotpop.com>
Subject: Re: [PATCH] fbdev: Fix crash if fb_set_var() called before register_framebuffer()
Date: Sat, 27 Nov 2004 09:38:43 +1100 [thread overview]
Message-ID: <1101508723.28047.43.camel@gaston> (raw)
In-Reply-To: <200411250115.50895.adaplas@hotpop.com>
On Thu, 2004-11-25 at 01:15 +0800, Antonino A. Daplas wrote:
> The field info->modelist is initialized during register_framebuffer. This
> field is also referred to in fb_set_var(). Thus a call to fb_set_var()
> before register_framebuffer() will cause a crash. A few drivers do this,
> notably controlfb. (This might fix reports of controlfb crashing in
> powermacs).
>
> .../...
Hi Antonio, I "missed" this modelist thingy. Can you explain what is the
logic ? There is now a modelist attached to fb_info used for mode
matching ? In this case, it makes sense to be able to add things to it
before register_framebuffer(). I mean, I would expect drivers to probe
at least their default head modes before registering the fb, since the
later will cause fbcon to try to setup a mode ...
Ben.
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
next prev parent reply other threads:[~2004-11-26 22:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-24 17:15 [PATCH] fbdev: Fix crash if fb_set_var() called before register_framebuffer() Antonino A. Daplas
2004-11-26 0:20 ` Mario Gaucher
2004-11-26 0:45 ` Antonino A. Daplas
2004-11-26 23:17 ` Mario Gaucher
2004-11-26 23:35 ` Antonino A. Daplas
2004-11-26 22:38 ` Benjamin Herrenschmidt [this message]
2004-11-27 2:56 ` Antonino A. Daplas
2004-11-27 4:15 ` Benjamin Herrenschmidt
2004-11-27 4:43 ` Antonino A. Daplas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101508723.28047.43.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=adaplas@hotpop.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.