All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: [Bluez-devel] SBC code cleanup
Date: Sat, 27 Nov 2004 22:49:25 +0100	[thread overview]
Message-ID: <1101592165.27074.31.camel@pegasus> (raw)

Hi Henryk,

I started with some cleaning up of the SBC code to better fit into
current coding conventions. My focus was on the sbc_synthesize_audio()
and sbc_analyze_audio() functions. While checking them and looking at
the code I think we also need this patch:

--- sbc/sbc.c   27 Nov 2004 21:39:38 -0000      1.23
+++ sbc/sbc.c   27 Nov 2004 21:46:01 -0000
@@ -523,7 +523,7 @@
        int i, j, k;
 
        /* Input 8 New Subband Samples */
-       for (i = 0; i < 7; i++)
+       for (i = 0; i < 8; i++)
                state->S[ch][i] = frame->sb_sample[blk][ch][i];
 
        /* Shifting */

Am I right, or do I miss something?

Regards

Marcel




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

             reply	other threads:[~2004-11-27 21:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-27 21:49 Marcel Holtmann [this message]
2004-11-28  4:32 ` [Bluez-devel] SBC code cleanup Henryk Plötz
2004-11-28  5:47   ` Marcel Holtmann
2004-11-28 17:23     ` Henryk Plötz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1101592165.27074.31.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.