From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Chris Wright <chrisw@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: Buffer overrun in arch/x86_64/sys_ia32.c:sys32_ni_syscall()
Date: Tue, 30 Nov 2004 12:46:13 -0800 [thread overview]
Message-ID: <1101847574.3951.3.camel@localhost> (raw)
In-Reply-To: <20041130103150.I14339@build.pdx.osdl.net>
On Tue, 2004-11-30 at 10:31 -0800, Chris Wright wrote:
> * Jeremy Fitzhardinge (jeremy@goop.org) wrote:
> > struct task_struct.comm is defined to be 16 chars, but
> > arch/x86_64/sys_ia32.c:sys32_ni_syscall() copies it into a static 8 byte
> > buffer, which will surely cause problems. This patch makes lastcomm[]
> > the right size, and makes sure it can't be overrun. Since the code also
> > goes to the effort of getting a local copy of current in "me", we may as
> > well use it for printing the message.
>
> Looks good, but you missed sys32_vm86_warning.
Hadn't got that far. Should we be worried that task_struct.comm might
not be \0-terminated, and therefore use ("... %.*s ...",
sizeof(lastcomm), lastcomm) in the printk's?
J
next prev parent reply other threads:[~2004-11-30 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-30 4:05 Buffer overrun in arch/x86_64/sys_ia32.c:sys32_ni_syscall() Jeremy Fitzhardinge
2004-11-30 18:31 ` Chris Wright
2004-11-30 20:46 ` Jeremy Fitzhardinge [this message]
2004-11-30 22:17 ` Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1101847574.3951.3.camel@localhost \
--to=jeremy@goop.org \
--cc=akpm@osdl.org \
--cc=chrisw@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.