All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: dhowells@redhat.com, nickpiggin@yahoo.com.au,
	nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop
Date: Fri, 03 Apr 2009 14:57:19 +0100	[thread overview]
Message-ID: <11023.1238767039@redhat.com> (raw)
In-Reply-To: <20090403134927.GA31907@infradead.org>

Christoph Hellwig <hch@infradead.org> wrote:

> > +			if (!aops->bmap)
> >  				goto check_error;
> 
> What are you doing using bmap?  You really shouldn't call into it from
> anywhere but FIBMAP.  Yes, swap currently does but it's a major pain
> in the neck and Peter has been working on a proper interface for swap
> for a while.

Checking to see whether there's a hole in the file.  If there's a hole, that
represents data I need to fetch; if there isn't that represents data I have in
the cache.  I don't care _where_ the data is, only whether it exists or not.

David

      reply	other threads:[~2009-04-03 13:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-03  9:41 [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop David Howells
2009-04-03  9:41 ` David Howells
2009-04-03  9:41 ` [PATCH 2/4] CacheFiles: Revert the addition of write_one_page() David Howells
2009-04-03 13:50   ` Christoph Hellwig
2009-04-03 13:53     ` David Howells
2009-04-03 13:53       ` David Howells
2009-04-04  5:55       ` Nick Piggin
2009-04-04  5:55         ` Nick Piggin
2009-04-03  9:41 ` [PATCH 3/4] FS-Cache: Use a radix tree to track pages being written rather than a page flag David Howells
2009-04-03  9:41   ` David Howells
2009-04-03  9:41 ` [PATCH 4/4] FS-Cache: Revert the addition of PG_owner_priv2/PG_fscache_write David Howells
2009-04-03  9:41   ` David Howells
2009-04-03  9:51 ` [PATCH 1/4] CacheFiles: Use the ->write() file op rather than a special kernel aop David Howells
2009-04-03  9:51   ` David Howells
2009-04-03 13:49 ` Christoph Hellwig
2009-04-03 13:57   ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11023.1238767039@redhat.com \
    --to=dhowells@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.