All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] Prepare patch bluez for the CoD in hci_conn
Date: Mon, 06 Dec 2004 10:14:36 +0100	[thread overview]
Message-ID: <1102324476.8510.85.camel@pegasus> (raw)
In-Reply-To: <1102352748.1779.3.camel@debian>

Hi Chen,

> I see your patch that you patch the hci_acl_connect()=81Cbut why not
> hci_conn_add()?
>=20
> I feel the latter is more appropriate.

no, it is not. The hci_conn_add is called at various times. It is called
for incoming and outgoing connections. We don't need to do a lookup at
the inquiry cache for an incoming connection, because we get the value
within the connection request event. The hci_acl_connect() is used to
create an outgoing connection and it already have to lookup the other
parameters from the inquiry cache. Do see the point?

Regards

Marcel




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2004-12-06  9:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-06 13:34 [Bluez-devel] Prepare patch bluez for the CoD in hci_conn Chen Bin
2004-12-06  6:40 ` Marcel Holtmann
2004-12-06 15:11   ` Chen Bin
2004-12-06  7:18     ` Marcel Holtmann
2004-12-06 15:50       ` Chen Bin
2004-12-06  8:07         ` Marcel Holtmann
2004-12-06 15:53       ` Chen Bin
2004-12-06  8:41         ` Marcel Holtmann
2004-12-06 16:54           ` Chen Bin
2004-12-06  9:04             ` Marcel Holtmann
2004-12-06 17:40               ` Chen Bin
2004-12-06  9:56                 ` Marcel Holtmann
2004-12-06 17:05           ` Chen Bin
2004-12-06  9:14             ` Marcel Holtmann [this message]
2004-12-06 17:21               ` Chen Bin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1102324476.8510.85.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.