From: Rusty Russell <rusty@rustcorp.com.au>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
Katrina Tsipenyuk <ytsipenyuk@fortifysoftware.com>,
katrina@fortifysoftware.com
Subject: Re: [PATCH][1/2] fix unchecked returns from kmalloc() (in kernel/module.c)
Date: Wed, 08 Dec 2004 12:57:54 +1100 [thread overview]
Message-ID: <1102471074.20129.14.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.61.0412072203070.3320@dragon.hygekrogen.localhost>
On Tue, 2004-12-07 at 22:23 +0100, Jesper Juhl wrote:
> Problem reported by Katrina Tsipenyuk and the Fortify Software engineering
> team in thread with subject "PROBLEM: unchecked returns from kmalloc() in
> linux-2.6.10-rc2".
IMHO a better fix is to
(1) mark percpu_modinit() as __init.
(2) ignore unhandled failures in __init functions.
With some exceptions, I would prefer to see a not_on_init(cond) macro
inside kmalloc et. al. which barfs in a consistent way when allocations,
registrations, etc. fail on boot.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
prev parent reply other threads:[~2004-12-08 4:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-07 21:23 [PATCH][1/2] fix unchecked returns from kmalloc() (in kernel/module.c) Jesper Juhl
2004-12-07 21:29 ` Jens Axboe
2004-12-07 22:56 ` Jesper Juhl
2004-12-07 22:57 ` Andries Brouwer
2004-12-08 7:01 ` Jens Axboe
2004-12-08 1:57 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1102471074.20129.14.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=juhl-lkml@dif.dk \
--cc=katrina@fortifysoftware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ytsipenyuk@fortifysoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.