From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page()
Date: Fri, 11 May 2007 11:03:37 +0100 [thread overview]
Message-ID: <11025.1178877817@redhat.com> (raw)
In-Reply-To: <20070511025822.a5aa5240.akpm@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
> Yes, it's a shame that there doesn't seem to be a fine-grained way of
> turning on -W's useful bits.
You can turn off -W's undesirable bits. For net/rxrpc/ and fs/afs/ at least,
adding:
CFLAGS += -W -Wno-unused-parameter
to the Makefile generates no warnings. Perhaps this should be added to the
master Makefile.
Adding -Wsign-compare finds some stuff that I will fix. It also finds some
stuff in the main and the networking headers. This is a really useful option
and found some tricky bugs in CacheFiles. I would endorse adding this
generally too.
David
next prev parent reply other threads:[~2007-05-11 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 14:33 [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page() David Howells
2007-05-10 14:33 ` [PATCH 2/2] AFS: Fix a couple of problems with unlinking AFS files David Howells
2007-05-10 23:19 ` [PATCH 1/2] AFS: Fix interminable loop in afs_write_back_from_locked_page() Andrew Morton
2007-05-11 9:49 ` David Howells
2007-05-11 9:58 ` Andrew Morton
2007-05-11 10:03 ` David Howells [this message]
2007-05-11 9:57 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11025.1178877817@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.