Re: c++ build flags, clang++, -Wnomismatched-tags?

[Matt Benjamin <mbenjamin@redhat.com>]

My annoyance with this warning is that I don't really want to see "friend struct foo" decls, which seems vaguely bogus?  The warnings could be eliminated by using class everywhere and adding public specifier where expected--but we shouldn't have to do that...

Matt

----- Original Message -----
> From: "Sage Weil" <sage@newdream.net>
> To: "Matt Benjamin" <mbenjamin@redhat.com>
> Cc: "Ceph Development" <ceph-devel@vger.kernel.org>
> Sent: Wednesday, January 20, 2016 5:57:17 PM
> Subject: Re: c++ build flags, clang++, -Wnomismatched-tags?
> 
> On Wed, 20 Jan 2016, Matt Benjamin wrote:
> > Hi Ceph C++ devs,
> > 
> > I notice building with clang lots of warnings like:
> > 
> >       'SequencerPosition' defined as a struct here but previously declared
> >       as a
> >       class [-Wmismatched-tags]
> > struct SequencerPosition {
> > ^
> > /home/mbenjamin/dev/rgw/ceph-upstream/src/os/ObjectMap.h:24:1: note: did
> > you
> >       mean struct here?
> > class SequencerPosition;
> > ^~~~~
> > struct
> > 3 warnings generated.
> > 
> > induced by -Wmismatched-tags, which apparently clang++ has by default.  As
> > a ISO C++ developer, I don't think of "struct" as a token that can be
> > mismatched with "class" in friend or forward declaration, but clearly the
> > authors of this warning do.
> > 
> > I think my intuition would be to disable this warning.  What do others
> > think?
> 
> No arguments from me, although I wouldn't object to someone who wants to
> clean up the mismatches either.
> 
> sage
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-707-0660
fax.  734-769-8938
cel.  734-216-5309