From: James Bottomley <James.Bottomley@SteelEye.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] tmscsim: implement change_queue_depth
Date: Thu, 23 Dec 2004 12:34:22 -0600 [thread overview]
Message-ID: <1103826862.5290.39.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.60.0412221305140.2636@poirot.grange>
On Wed, 2004-12-22 at 13:15 +0100, Guennadi Liakhovetski wrote:
> Further to my recent doubts wrt change_queue_depth semantics, I decided to
> just implement this function for tmscsim following comments in
> scsi_host.h. If this gets accepted in this form (returning -EIO if depth
> != sdev->queue_depth after scsi_adjust_depth_queue), I'll submit patches
> to 53c700.c and a comment-modification to scsi_host.h.
Actually, there's currently no way for scsi_adjust_queue_depth to fail,
so the check really isn't necessary.
Also, even if it were, the correct return would be either -EINVAL, or
the true nature of the error (most likely -ENOMEM).
The idea of the error return is more for drivers that have to allocate
internal resources to tag queues, so they can fail in those allocations.
James
next prev parent reply other threads:[~2004-12-23 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-22 12:15 [PATCH] tmscsim: implement change_queue_depth Guennadi Liakhovetski
2004-12-23 18:34 ` James Bottomley [this message]
2004-12-25 0:36 ` Guennadi Liakhovetski
2004-12-26 15:49 ` James Bottomley
2004-12-26 21:49 ` Guennadi Liakhovetski
2004-12-27 18:31 ` James Bottomley
2004-12-28 0:29 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1103826862.5290.39.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.