From: Rusty Russell <rusty@rustcorp.com.au>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter development mailing list <netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] Fix conntrack iteration.
Date: Tue, 28 Dec 2004 12:22:42 +1100 [thread overview]
Message-ID: <1104196962.6910.10.camel@localhost.localdomain> (raw)
In-Reply-To: <41CD79F8.5060003@trash.net>
On Sat, 2004-12-25 at 15:32 +0100, Patrick McHardy wrote:
> > WRITE_LOCK(&ip_conntrack_lock);
> > - /* Make sure don't leave any orphaned expectations lying around */
> > - if (ct->expecting)
> > - remove_expectations(ct, 1);
> > + BUG_ON(ct->expecting);
>
> This doesn't look right. The call to remove_expectations was
> added to deal with the TFTP helper registering expectations
> for unconfirmed connections.
Ah, right! I'll add a comment there instead. I couldn't see how it
could happen, but this makes sense.
Thanks,
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
next prev parent reply other threads:[~2004-12-28 1:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-24 11:35 [PATCH] Fix conntrack iteration Rusty Russell
2004-12-25 14:32 ` Patrick McHardy
2004-12-28 1:22 ` Rusty Russell [this message]
2004-12-28 1:45 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104196962.6910.10.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.