From: Lee Revell <rlrevell@joe-job.com>
To: alsa-devel <alsa-devel@lists.sourceforge.net>
Subject: Re: [PATCH] emu10k1: change "Music" to "Synth" in mixer control names.
Date: Tue, 28 Dec 2004 21:07:44 -0500 [thread overview]
Message-ID: <1104286064.27377.15.camel@krustophenia.net> (raw)
In-Reply-To: <1104283454.27377.3.camel@krustophenia.net>
On Tue, 2004-12-28 at 20:24 -0500, Lee Revell wrote:
> snd_emu10k1_init_stereo_control(&controls[nctl++], "Wave Playback Volume", gpr, 100);
> gpr += 2;
I have noticed that many of the PCM controls are assigned names like
"Wave Playback Volume", and later renamed to "PCM Playback Volume" in
the devinit routine.
476 static char *emu10k1_rename_ctls[] = {
477 "Surround Digital Playback Volume", "Surround Playback Volume",
478 "Center Digital Playback Volume", "Center Playback Volume",
479 "LFE Digital Playback Volume", "LFE Playback Volume",
480 NULL
481 };
503 static char *audigy_rename_ctls[] = {
504 /* use conventional names */
505 "Wave Playback Volume", "PCM Playback Volume",
506 /* "Wave Capture Volume", "PCM Capture Volume", */
507 "Wave Master Playback Volume", "Master Playback Volume",
508 "AMic Playback Volume", "Mic Playback Volume",
509 NULL
510 };
560 if (emu->audigy)
561 c = audigy_rename_ctls;
562 else
563 c = emu10k1_rename_ctls;
564 for (; *c; c += 2)
565 rename_ctl(card, c[0], c[1]);
Maybe I am missing something but why not just call it "PCM Playback
Volume" in the first place, and clean up the code a bit?
Lee
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
next prev parent reply other threads:[~2004-12-29 2:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-29 1:24 [PATCH] emu10k1: change "Music" to "Synth" in mixer control names Lee Revell
2004-12-29 2:07 ` Lee Revell [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-12-29 8:40 Peter Zubaj
2004-12-29 12:21 ` Takashi Iwai
2004-12-29 12:37 Peter Zubaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1104286064.27377.15.camel@krustophenia.net \
--to=rlrevell@joe-job.com \
--cc=alsa-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.