All of lore.kernel.org
 help / color / mirror / Atom feed
From: Art Haas <ahaas-baQpNawxmjLR7s880joybQ@public.gmane.org>
To: Dominik Brodowski
	<linux-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
Cc: len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Re: Error building drivers/acpi/processor_idle.c in current BK
Date: Wed, 29 Dec 2004 10:17:52 -0600	[thread overview]
Message-ID: <1104337071.6187.11.camel@localhost.localdomain> (raw)
In-Reply-To: <20041229160708.GA8982-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>

On Wed, 2004-12-29 at 10:07, Dominik Brodowski wrote:
> On Wed, Dec 29, 2004 at 09:52:46AM -0600, Art Haas wrote:
> > Hi.
> > 
> > I tried building Linus's BK tree this morning using the development
> > version of GCC. Unfortunately there was a snag when building some of the
> > acpi files ...
> > 
> > drivers/acpi/processor_idle.c:57: error: static declaration of
> > ???pm_idle_save??? follows non-static declaration
> > include/acpi/processor.h:180: error: previous declaration of
> > ???pm_idle_save??? was here
> > 
> > The files compile without problem in GCC 3.3.
> 
> Thanks for reporting this issue. Could you test the attached patch, please?
> gcc-Version 3.4.3 20041125 (Gentoo Linux 3.4.3-r1, ssp-3.4.3-0, pie-8.7.7)
> did and does not complain...
> 
> 
> As pm_idle_save is static to processor_idle by now, having it defined
> differently in processor.h breaks compilation with latest gcc, as noted
> by Art Haas.
> 
> Signed-off-by: Dominik Brodowski <linux-JhLEnvuH02M@public.gmane.org>
> ---
> 
>  include/acpi/processor.h |    1 -
>  1 files changed, 1 deletion(-)
> 
> Index: 2.6.10/include/acpi/processor.h
> ===================================================================
> --- 2.6.10.orig/include/acpi/processor.h	2004-12-29 17:03:30.742089456 +0100
> +++ 2.6.10/include/acpi/processor.h	2004-12-29 17:04:02.449441921 +0100
> @@ -177,7 +177,6 @@
>  /* for communication between multiple parts of the processor kernel module */
>  extern struct acpi_processor	*processors[NR_CPUS];
>  extern struct acpi_processor_errata errata;
> -extern void (*pm_idle_save)(void);
>  
>  /* in processor_perflib.c */
>  #ifdef CONFIG_CPU_FREQ

Removing this line allows processor_idle.c to compile without problems.

Art Haas



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now. 
http://productguide.itmanagersjournal.com/

      parent reply	other threads:[~2004-12-29 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-29 15:52 Error building drivers/acpi/processor_idle.c in current BK Art Haas
     [not found] ` <1104335566.6187.8.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2004-12-29 16:07   ` [PATCH] " Dominik Brodowski
     [not found]     ` <20041229160708.GA8982-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org>
2004-12-29 16:17       ` Art Haas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1104337071.6187.11.camel@localhost.localdomain \
    --to=ahaas-baqpnawxmjlr7s880joybq@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-X3ehHDuj6sIIGcDfoQAp7BvVK+yQ3ZXh@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.