From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [patch 2/3] Replace pci_find_device with pci_get_device
Date: Mon, 10 Jan 2005 21:21:56 +0000 [thread overview]
Message-ID: <1105392116.29910.50.camel@eeyore> (raw)
In-Reply-To: <20050110194635.844AE1F203@trashy.coderock.org>
On Mon, 2005-01-10 at 13:09 -0800, Jesse Barnes wrote:
> On Monday, January 10, 2005 11:46 am, domen@coderock.org wrote:
> > - while ((dev = pci_find_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
> > + while ((dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev)) != NULL)
> > acpi_pci_irq_enable(dev);
>
> Shouldn't this be for_each_pci_dev(dev) acpi_pci_irq_enable(dev); instead?
> Bjorn?
They're equivalent, right? Looks OK to me either way. I guess
if you switch to for_each_pci_dev(), you could switch the one
in sba_iommu.c, too.
next prev parent reply other threads:[~2005-01-10 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-10 19:46 [patch 2/3] Replace pci_find_device with pci_get_device domen
2005-01-10 21:09 ` Jesse Barnes
2005-01-10 21:18 ` Hanna Linder
2005-01-10 21:21 ` Bjorn Helgaas [this message]
2005-01-10 21:37 ` Hanna Linder
2005-01-11 0:22 ` [patch 2/3] Replace pci_find_device with pci_get_device - pci.c Hanna Linder
2005-01-11 0:23 ` [patch 2/3] Replace pci_find_device with pci_get_device - sba_iommu.c Hanna Linder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1105392116.29910.50.camel@eeyore \
--to=bjorn.helgaas@hp.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.