[Bluez-devel] Re: out of range

[Marcel Holtmann <marcel@holtmann.org>]

Hi Jean,

> > I had your patch in my -mh patches for some time, but then it got out of
> > sync with the mainline development and I dropped it. However I want your
> > patch inside the kernel, but I still don't like the way of notification.
> > What do you think about setting sk->sk_err with an error code like we do
> > for the reliable feature that detects ACL packet errors. Even if the HCI
> > events itself are global I like to do the notification through the
> > socket interfaces of L2CAP and RFCOMM. Comments?
> 
> 	I'm afraid I'm not familiar with the sk->sk_err stuff. My
> assumption is that a write/read would return the error. Yep, I think
> that would be much simpler/smoother/straightforward for most
> applications, as most applications don't open HCI sockets.

my neither, but Max introduced it for the L2CAP reliable check that was
needed for the Bluetooth qualification. I think we can also use it for
detecting ACL stalls or the reason why a connection is terminated.

> 	However, I was personally using this feature with BNEP sockets
> (i.e. monitoring PAN), and pand doesn't do any read/write on the L2CAP
> socket once the BNEP connection is established. So, in this case, the
> HCI event makes more sense.

I don't know if select() or poll() also returns the error value from
sk->sk_err, but if then this is maybe a nice way and we can keep the
handling inside the application without the need of root rights for the
special HCI events.

Anyone who volunteers for writing a patch for it?

Regards

Marcel




-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel