From: Dave Kleikamp <shaggy@austin.ibm.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] Re: [PATCH 6/40] fs/jfs_logmgr: replace schedule_timeout() with
Date: Thu, 20 Jan 2005 20:34:49 +0000 [thread overview]
Message-ID: <1106253289.7970.3.camel@localhost> (raw)
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
On Thu, 2005-01-20 at 11:02 -0800, Nishanth Aravamudan wrote:
> Hi,
>
> Please consider applying.
I will. It looks good.
> Description: Use msleep() instead of schedule_timeout() to guarantee the task
> delays as expected. The current code uses TASK_INTERRUPTIBLE; however, it does
> not check for signals, so I do not think the change to msleep() is necessarily
> bad.
Right, TASK_INTERRUPTIBLE doesn't make sense here, so msleep is a better
fit.
Thanks,
Shaggy
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> --- 2.6.11-rc1-kj-v/fs/jfs/jfs_logmgr.c 2005-01-15 16:55:41.000000000 -0800
> +++ 2.6.11-rc1-kj/fs/jfs/jfs_logmgr.c 2005-01-18 10:53:46.000000000 -0800
> @@ -67,6 +67,7 @@
> #include <linux/buffer_head.h> /* for sync_blockdev() */
> #include <linux/bio.h>
> #include <linux/suspend.h>
> +#include <linux/delay.h>
> #include "jfs_incore.h"
> #include "jfs_filsys.h"
> #include "jfs_metapage.h"
> @@ -1612,8 +1613,7 @@ void jfs_flush_journal(struct jfs_log *l
> */
> if ((!list_empty(&log->cqueue)) || !list_empty(&log->synclist)) {
> for (i = 0; i < 800; i++) { /* Too much? */
> - current->state = TASK_INTERRUPTIBLE;
> - schedule_timeout(HZ / 4);
> + msleep(250);
> if (list_empty(&log->cqueue) &&
> list_empty(&log->synclist))
> break;
--
David Kleikamp
IBM Linux Technology Center
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-01-20 20:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1106253289.7970.3.camel@localhost \
--to=shaggy@austin.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.