From: James Bottomley <James.Bottomley@SteelEye.com>
To: "Ju, Seokmann" <sju@lsil.com>
Cc: Matt Domsch <Matt_Domsch@Dell.com>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>,
"Bagalkote, Sreenivas" <sreenib@lsil.com>,
"Mukker, Atul" <Atulm@lsil.com>
Subject: RE: [Announce] megaraid_mbox 2.20.4.4 patch
Date: Wed, 02 Feb 2005 16:43:21 -0600 [thread overview]
Message-ID: <1107384201.4541.30.camel@mulgrave> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E570366265E@exa-atlanta>
On Wed, 2005-02-02 at 10:56 -0500, Ju, Seokmann wrote:
> + .sdev_attrs = megaraid_device_attrs,
> + .shost_attrs = megaraid_class_device_attrs,
These are, perhaps, slightly confusing names. The terms device and
class_device have well defined meanings in the generic device model,
neither of which is what you mean here. Why not simply
megaraid_sdev_attrs and megaraid_shost_attrs?
Other than this, it looks fine to me too.
James
next prev parent reply other threads:[~2005-02-02 22:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-02 15:56 [Announce] megaraid_mbox 2.20.4.4 patch Ju, Seokmann
2005-02-02 22:43 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-02-03 19:44 Ju, Seokmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107384201.4541.30.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=Atulm@lsil.com \
--cc=Matt_Domsch@Dell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sju@lsil.com \
--cc=sreenib@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.