From: Andrew Vasquez <andrew.vasquez@qlogic.com>
To: Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>
Cc: andrew.vasquez@qlogic.com
Subject: Re: PATCH [1/3] qla2xxx: remove internal queuing.
Date: Fri, 04 Feb 2005 13:52:40 -0800 [thread overview]
Message-ID: <1107553960.15462.1.camel@plap.san.rr.com> (raw)
In-Reply-To: <1107545071.14183.15.camel@plap.san.rr.com>
Small incremental patch which fixes some annoyances sighted by Christoph
Hellwig.
* Correct backing-out of msleep() calls
* remove superfluous return in qla2xxx_slave_destroy.
Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
===== drivers/scsi/qla2xxx/qla_os.c 1.56 vs edited =====
--- 1.56/drivers/scsi/qla2xxx/qla_os.c 2005-02-04 10:24:28 -08:00
+++ edited/drivers/scsi/qla2xxx/qla_os.c 2005-02-04 13:26:23 -08:00
@@ -467,8 +467,7 @@ qla2x00_wait_for_hba_online(scsi_qla_hos
test_bit(ISP_ABORT_RETRY, &ha->dpc_flags) ||
ha->dpc_active) && time_before(jiffies, wait_online)) {
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep(1000);
}
if (ha->flags.online)
return_status = QLA_SUCCESS;
@@ -509,8 +508,7 @@ qla2x00_wait_for_loop_ready(scsi_qla_hos
atomic_read(&ha->loop_state) == LOOP_DOWN) ||
test_bit(CFG_ACTIVE, &ha->cfg_flags) ||
atomic_read(&ha->loop_state) != LOOP_READY) {
- set_current_state(TASK_UNINTERRUPTIBLE);
- schedule_timeout(HZ);
+ msleep(1000);
if (time_after_eq(jiffies, loop_timeout)) {
return_status = QLA_FUNCTION_FAILED;
break;
@@ -1064,7 +1062,6 @@ static void
qla2xxx_slave_destroy(struct scsi_device *sdev)
{
sdev->hostdata = NULL;
- return;
}
/**
next prev parent reply other threads:[~2005-02-04 21:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-04 19:21 PATCH [0/3] qla2xxx: new experimental changes Andrew Vasquez
2005-02-04 19:24 ` PATCH [1/3] qla2xxx: remove internal queuing Andrew Vasquez
2005-02-04 21:52 ` Andrew Vasquez [this message]
2005-02-04 19:26 ` PATCH [2/3] qla2xxx: add FC remote port support Andrew Vasquez
2005-02-04 19:27 ` PATCH [3/3] qla2xxx: remove internal lun discovery Andrew Vasquez
2005-02-04 20:35 ` PATCH [0/3] qla2xxx: new experimental changes Christoph Hellwig
2005-02-04 21:09 ` Andrew Vasquez
2005-02-04 22:46 ` Jeff Garzik
2005-02-04 22:52 ` Andrew Vasquez
2005-02-04 21:00 ` PATCH [3/3] qla2xxx: remove internal lun discovery Andrew Vasquez
2005-02-04 23:11 ` PATCH [0/3] qla2xxx: new experimental changes Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1107553960.15462.1.camel@plap.san.rr.com \
--to=andrew.vasquez@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.