All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Tom Rini <trini@kernel.crashing.org>, Olaf Hering <olh@suse.de>,
	linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: make -j12 all fails in uImage target
Date: Mon, 07 Feb 2005 10:43:11 +1100	[thread overview]
Message-ID: <1107733391.30303.66.camel@gaston> (raw)
In-Reply-To: <20050206225323.GA16821@mars.ravnborg.org>

On Sun, 2005-02-06 at 23:53 +0100, Sam Ravnborg wrote:

> The problem is that the images/ sub directory is visited before the
> prerequisites are finished.
> I have no good way to debug this - I can see it based on the Makefile and
> the output Olaf included.
> 
> Also the problem Olaf describe is just a cp of a half finished file.

We had a similar problem with paul recently where the build worked but
the resulting zImage contained a corrupted file as the
objcopy/gzip/whatever wasn't fully finished when the zImage file got
linked.
> 
> So the fix is to let the images/ directory depends on the rest of the
> directories.
> 
> Something like this may do the trick:

We should maybe also have an explicit dependency on vmlinux no ? Or is
this handled already for the boot dir as a whole ?

> $(obj)/images: $(addprefix $(obj)/,$(subdir-y) $(bootdir-y))
> 	$(Q)$(MAKE) $(build)=$@
> 
> And then delete the assignment of images to subdir-y
> 
> 
> Another solution would be to get rid on the images/ drectory and place
> outputfiles where they are being built.
> 
> 	Sam
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
-- 
Benjamin Herrenschmidt <benh@kernel.crashing.org>

  reply	other threads:[~2005-02-06 23:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-06 12:40 make -j12 all fails in uImage target Olaf Hering
2005-02-06 21:51 ` Tom Rini
2005-02-06 21:57   ` Olaf Hering
2005-02-06 22:53   ` Sam Ravnborg
2005-02-06 23:43     ` Benjamin Herrenschmidt [this message]
2005-02-07  5:39       ` Sam Ravnborg
2005-02-06 23:50     ` Tom Rini
2005-02-07  8:29     ` Olaf Hering
2005-02-16 15:54       ` Tom Rini
2005-05-25 21:34     ` Olaf Hering
2005-07-12 21:29 ` [PATCH] " Olaf Hering
2005-07-12 21:36   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1107733391.30303.66.camel@gaston \
    --to=benh@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=olh@suse.de \
    --cc=sam@ravnborg.org \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.