Re: Fw: Fw: [Bugme-new] [Bug 4180] New: masquarade and source ip

[Rusty Russell <rusty@rustcorp.com.au>]

On Mon, 2005-02-07 at 12:14 -0800, David S. Miller wrote:
> On Mon, 07 Feb 2005 21:15:50 +0100
> Patrick McHardy <kaber@trash.net> wrote:
> 
> > >Didn't this get changed on purpose?
> >
> > Yes. One thing we could do to make it more consistent is treat
> > local packets the same way as forwarded ones in MASQUERADE, then
> > at least all packets would have the same source address. This check
> > currently prevents local packets from beeing masqueraded:
> > 
> >         /* FIXME: For the moment, don't do local packets, breaks
> >            testsuite for 2.3.49 --RR */
> >         if ((*pskb)->sk)
> >                 return NF_ACCEPT;
> > 
> > I'm not sure if we can simply remove it, maybe Rusty remembers :)

Remove it; nothing should break.  The network code used to hate local
packets getting changed, but we do the right thing these days (if not,
that's another bug).

> Ok, when you figure out what's going on please post the analysis to
> netdev et al., and in particular Andrew or Stephen, so the bugzilla
> can get closed properly.

We vastly simplified the masquerade code to use inet_select_addr(),
because its purpose is for dynamic links.  This user should be using
SNAT to specify exactly what he/she wants.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman