Re: [RFC][PATCH] no per-arch mem_map init

[Dave Hansen <haveblue@us.ibm.com>]

On Tue, 2005-02-08 at 20:04 -0500, Bob Picco wrote:
> > -		mem_map = contig_page_data.node_mem_map = vmem_map;
> > +		NODE_DATA(0)->node_mem_map = vmem_map;
> This has to be changed to.
> 		mem_map = NODE_DATA(0)->node_mem_map = vmem_map;
> >  		free_area_init_node(0, &contig_page_data, zones_size,
> >  				    0, zholes_size);
> >  
> [snip]
> I actually submitted an identical change within my last patchset to lhms.

Good to know.  I hadn't actually noticed that bit in your patch.  It's
another good example why to split things up into as many small, logical
pieces as possible.  

> Not making this change requires changing use of mem_map throughout contig.c
> and one BUG assertion in init.c.  I haven't tested this patch but it was
> indirectly tested by me in FLATMEM configuration for lhms.

Hmm.  Do you really need the 'mem_map = ' part?  I *think*
free_area_init_node() calls alloc_node_mem_map(), which should do that
exact assignment for you.  

-- Dave

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>