From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 4/5] drm: omapdrm: Store the Z order in the plane state zpos field
Date: Mon, 24 Apr 2017 17:00:58 +0300 [thread overview]
Message-ID: <11080507.OQ3G0dHdUC@avalon> (raw)
In-Reply-To: <5e3c1ca5-6a7c-644f-015a-670eaf9ea038@ti.com>
Hi Tomi,
On Monday 24 Apr 2017 12:40:10 Tomi Valkeinen wrote:
> On 15/04/17 12:16, Laurent Pinchart wrote:
> > The DRM core implements a standard "zpos" property to control planes
> > ordering. The omapdrm driver implements a similar property named
> > "zorder". Although we can't switch to DRM core handling of the "zpos"
> > property for backward compatibility reasons, we can store the zorder
> > value in the drm_plane_state zpos field, saving us from having to
> > implement custom plane state handling.
>
> I'm fine with the zpos change, but I'd like to keep the omap_plane_state
> around. It'll be empty after this patch, but we have a bunch of
> properties we need to add. Some can be added as common DRM properties,
> but perhaps not all. It's so much easier to handle those patches if the
> plumbing is there already, instead of adding it back.
How about reverting the needed parts of this patch at that time then ? I think
it would be better than keeping useless code around until a hypothetical time
when it will be needed.
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-04-24 13:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 9:16 [PATCH v2 0/5] omapdrm: fences and zpos Laurent Pinchart
2017-04-15 9:16 ` [PATCH v2 1/5] drm: omapdrm: Handle events when enabling/disabling CRTCs Laurent Pinchart
2017-04-24 9:59 ` Tomi Valkeinen
2017-04-15 9:16 ` [PATCH v2 2/5] drm: omapdrm: Use DRM core's atomic commit helper Laurent Pinchart
2017-04-27 10:45 ` Tomi Valkeinen
2017-04-15 9:16 ` [PATCH v2 3/5] drm: omapdrm: Remove legacy buffer synchronization support Laurent Pinchart
2017-04-18 6:20 ` Daniel Vetter
2017-04-18 8:59 ` Laurent Pinchart
2017-04-15 9:16 ` [PATCH v2 4/5] drm: omapdrm: Store the Z order in the plane state zpos field Laurent Pinchart
2017-04-24 9:40 ` Tomi Valkeinen
2017-04-24 14:00 ` Laurent Pinchart [this message]
2017-04-25 9:01 ` Tomi Valkeinen
2017-04-15 9:16 ` [PATCH v2 5/5] drm: omapdrm: Add zpos property Laurent Pinchart
2017-04-24 9:37 ` Tomi Valkeinen
2017-04-24 14:00 ` Laurent Pinchart
2017-04-24 14:05 ` Laurent Pinchart
2017-04-25 8:56 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11080507.OQ3G0dHdUC@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.