Re: [RFC] New method for adding AC97 SNDRV_CTL_ELEM_TYPE_ENUMERATED controls

[Liam Girdwood <Liam.Girdwood@wolfsonmicro.com>]

On Thu, 2005-02-10 at 17:10, Takashi Iwai wrote:

> Instead, we can pass the pointer of the enum record (cast to unsigned
> long) in private_value field, so that the enum texts can be given
> separately.  For example,
> 
> struct ac97_enum {
> 	unsigned char reg;
> 	unsigned char shift_l;
> 	unsigned char shift_r;
> 	unsigned short mask;
> 	const char **texts;
> };
> 
> static int snd_ac97_info_enum(snd_kcontrol_t *kcontrol,
> 				snd_ctl_elem_info_t *info)
> {
> 	struct ac97_enum *rec = (struct ac97_enum *)kcontrol->priavate_value;
> 	...
> 	strcpy(uinfo->value.enumerated.name, rec->texts[uinfo->value.enumerated.item]);
> 	...
> }

That's fine with me and cleaner.

I'll submit a patch.

Liam



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click