From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Revell Subject: Re: [PATCH] emu10k1: fix efx_voices_mask setting for SBLive Date: Sat, 26 Feb 2005 19:29:59 -0500 Message-ID: <1109464199.1814.23.camel@krustophenia.net> References: <1109463592.1814.12.camel@krustophenia.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-pkbO8rofYA42F2mmAc9A" In-Reply-To: <1109463592.1814.12.camel@krustophenia.net> Sender: alsa-devel-admin@lists.sourceforge.net Errors-To: alsa-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: alsa-devel Cc: Takashi Iwai , James Courtier-Dutton List-Id: alsa-devel@alsa-project.org --=-pkbO8rofYA42F2mmAc9A Content-Type: text/plain Content-Transfer-Encoding: 7bit On Sat, 2005-02-26 at 19:19 -0500, Lee Revell wrote: > Also, the "EFX Voices Mask" control is renamed to "Captured FX8010 > Outputs". This is a trick to ensure the default mixer settings are > loaded when users upgrade from 1.0.8. Otherwise, the upgrade process > will probably restore the old settings which results in the > "multichannel" capture device only having two channels. I could not > think of a better way to get around this issue, and the alternative > seems to be a slew of bug reports. Half the testers reported this to me > as a bug already. > > Anyway, I think the new name is clearer anyway, because there's no > reason to tell userspace the hardware stores this value as a mask, and > "voices" is confusing because it implies some relation to the 64 > wavetable/PCM voices. Sorry, wrong patch. Lee --=-pkbO8rofYA42F2mmAc9A Content-Disposition: attachment; filename=sblive-fix-default-voices-mask.patch Content-Type: text/x-patch; name=sblive-fix-default-voices-mask.patch; charset=ANSI_X3.4-1968 Content-Transfer-Encoding: 7bit Index: alsa/alsa-kernel/pci/emu10k1/emupcm.c =================================================================== RCS file: /cvsroot/alsa/alsa-kernel/pci/emu10k1/emupcm.c,v retrieving revision 1.40 diff -u -r1.40 emupcm.c --- alsa/alsa-kernel/pci/emu10k1/emupcm.c 17 Feb 2005 14:49:50 -0000 1.40 +++ alsa/alsa-kernel/pci/emu10k1/emupcm.c 27 Feb 2005 00:07:57 -0000 @@ -1405,7 +1405,7 @@ static snd_kcontrol_new_t snd_emu10k1_pcm_efx_voices_mask = { .iface = SNDRV_CTL_ELEM_IFACE_PCM, - .name = "EFX voices mask", + .name = "Captured FX8010 Outputs", .info = snd_emu10k1_pcm_efx_voices_mask_info, .get = snd_emu10k1_pcm_efx_voices_mask_get, .put = snd_emu10k1_pcm_efx_voices_mask_put @@ -1690,7 +1690,7 @@ emu->efx_voices_mask[0] = 0; emu->efx_voices_mask[1] = 0xffff; } else { - emu->efx_voices_mask[0] = 0xffff; + emu->efx_voices_mask[0] = 0xffff0000; emu->efx_voices_mask[1] = 0; } snd_ctl_add(emu->card, snd_ctl_new1(&snd_emu10k1_pcm_efx_voices_mask, emu)); --=-pkbO8rofYA42F2mmAc9A-- ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click