From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Zwane Mwaikambo <zwane@arm.linux.org.uk>,
linuxppc64-dev <linuxppc64-dev@ozlabs.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
nathanl@austin.ibm.com
Subject: Re: [PATCH] PPC64: Generic hotplug cpu support
Date: Mon, 28 Feb 2005 09:22:51 +1100 [thread overview]
Message-ID: <1109542971.14993.217.camel@gaston> (raw)
In-Reply-To: <20050227031655.67233bb5.akpm@osdl.org>
On Sun, 2005-02-27 at 03:16 -0800, Andrew Morton wrote:
> Zwane Mwaikambo <zwane@arm.linux.org.uk> wrote:
> >
> > Patch provides a generic hotplug cpu implementation, with the only current
> > user being pmac.
>
> BUG: using smp_processor_id() in preemptible [00000001] code: swapper/0
> caller is .native_idle+0x30/0x60
>
> --- 25/arch/ppc64/kernel/idle.c~ppc64-generic-hotplug-cpu-support-fix 2005-02-27 11:12:47.000000000 -0700
> +++ 25-akpm/arch/ppc64/kernel/idle.c 2005-02-27 11:13:03.000000000 -0700
> @@ -294,7 +294,7 @@ static int native_idle(void)
> if (need_resched())
> schedule();
>
> - if (cpu_is_offline(smp_processor_id()) &&
> + if (cpu_is_offline(_smp_processor_id()) &&
> system_state == SYSTEM_RUNNING)
> cpu_die();
> }
> _
This is the idle loop. Is that ever supposed to be preempted ?
Ben.
next prev parent reply other threads:[~2005-02-27 22:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-01 18:25 [PATCH] PPC64: Generic hotplug cpu support Zwane Mwaikambo
2005-02-27 11:16 ` Andrew Morton
2005-02-27 22:22 ` Benjamin Herrenschmidt [this message]
2005-02-27 22:49 ` Andrew Morton
2005-03-02 1:47 ` [PATCH] explicitly bind idle tasks Nathan Lynch
2005-03-02 3:13 ` Zwane Mwaikambo
2005-03-07 23:01 ` Joel Schopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109542971.14993.217.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=nathanl@austin.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.