From: Thomas Monjalon <thomas@monjalon.net>
To: Itai Sharoni <isharoni@nvidia.com>
Cc: dev@dpdk.org, mkashani@nvidia.com, rasland@nvidia.com,
Itai Sharoni <isharoni@nvidia.com>,
stable@dpdk.org, Bing Zhao <bingz@nvidia.com>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ophir Munk <ophirmu@nvidia.com>
Subject: Re: [PATCH] net/mlx5/windows: fix match criteria in flow creation
Date: Thu, 13 Nov 2025 23:37:40 +0100 [thread overview]
Message-ID: <11095513.IZOipudI63@thomas> (raw)
In-Reply-To: <20251113122642.1193-1-isharoni@nvidia.com>
13/11/2025 13:26, Itai Sharoni:
> Currently the Windows implementation hardcodes match criteria to
> MLX5_MATCH_OUTER_HEADERS when creating flow rules, which prevents
> matching on inner headers and other criteria types like NVGRE.
>
> The fix uses the matcher's match_criteria_enable attribute instead
> of hardcoding OUTER_HEADERS, and moves the assignment outside the
> action switch block to apply to all cases.
>
> NVGRE item type is also added to the supported items list.
Why adding only NVGRE?
Should we mention which tunnels are supported on Windows in the doc?
next prev parent reply other threads:[~2025-11-13 22:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 12:26 [PATCH] net/mlx5/windows: fix match criteria in flow creation Itai Sharoni
2025-11-13 22:37 ` Thomas Monjalon [this message]
2025-11-17 8:45 ` [PATCH v2] " Itai Sharoni
2025-11-18 14:30 ` Raslan Darawsheh
2025-11-17 9:10 ` [PATCH] " Itai Sharoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11095513.IZOipudI63@thomas \
--to=thomas@monjalon.net \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=isharoni@nvidia.com \
--cc=matan@nvidia.com \
--cc=mkashani@nvidia.com \
--cc=ophirmu@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.