From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Cc: dlsy@snoqualmie.dp.intel.com
Subject: [PATCH] PCI Hotplug: Fix OSHP calls in shpchp and pciehp drivers
Date: Fri, 4 Mar 2005 12:53:57 -0800 [thread overview]
Message-ID: <1109969637954@kroah.com> (raw)
In-Reply-To: <11099696372884@kroah.com>
ChangeSet 1.1998.11.17, 2005/02/17 15:05:32-08:00, dlsy@snoqualmie.dp.intel.com
[PATCH] PCI Hotplug: Fix OSHP calls in shpchp and pciehp drivers
Here is a patch to fix a problem in OSHP calls in shpchp and pciehp
drivers that was detected in 2.6.11-rc3. In this kernel, calls to
acpi_evaluate_object() to evaluate OSHP returned AE_BUFFER_OVERFLOW
with the existing code. Earlier kernels didn't return this error
code. The correct fix should be making return_buffer pointer NULL
for no value is returned from this method.
Signed-off-by: Dely Sy <dely.l.sy@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/pci/hotplug/pciehprm_acpi.c | 3 +--
drivers/pci/hotplug/shpchprm_acpi.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff -Nru a/drivers/pci/hotplug/pciehprm_acpi.c b/drivers/pci/hotplug/pciehprm_acpi.c
--- a/drivers/pci/hotplug/pciehprm_acpi.c 2005-03-04 12:42:18 -08:00
+++ b/drivers/pci/hotplug/pciehprm_acpi.c 2005-03-04 12:42:18 -08:00
@@ -254,10 +254,9 @@
{
acpi_status status;
u8 *path_name = acpi_path_name(ab->handle);
- struct acpi_buffer ret_buf = { 0, NULL};
/* run OSHP */
- status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, &ret_buf);
+ status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, NULL);
if (ACPI_FAILURE(status)) {
err("acpi_pciehprm:%s OSHP fails=0x%x\n", path_name, status);
oshp_run_status = (status == AE_NOT_FOUND) ? OSHP_NOT_EXIST : OSHP_RUN_FAILED;
diff -Nru a/drivers/pci/hotplug/shpchprm_acpi.c b/drivers/pci/hotplug/shpchprm_acpi.c
--- a/drivers/pci/hotplug/shpchprm_acpi.c 2005-03-04 12:42:18 -08:00
+++ b/drivers/pci/hotplug/shpchprm_acpi.c 2005-03-04 12:42:18 -08:00
@@ -242,10 +242,9 @@
{
acpi_status status;
u8 *path_name = acpi_path_name(ab->handle);
- struct acpi_buffer ret_buf = { 0, NULL};
/* run OSHP */
- status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, &ret_buf);
+ status = acpi_evaluate_object(ab->handle, METHOD_NAME_OSHP, NULL, NULL);
if (ACPI_FAILURE(status)) {
err("acpi_pciehprm:%s OSHP fails=0x%x\n", path_name, status);
} else
next prev parent reply other threads:[~2005-03-04 23:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-04 20:53 [BK PATCH] PCI update for 2.6.11 Greg KH
2005-03-04 20:53 ` [PATCH] convert pci_dev->slot_name usage to pci_name() Greg KH
2005-03-04 20:53 ` [PATCH] Remove pci_dev->slot_name Greg KH
2005-03-04 20:53 ` [PATCH] PCI Hotplug: Remove unneeded instructions from ibmphp_pci.c Greg KH
2005-03-04 20:53 ` [PATCH] PCI: pci_proc_domain Greg KH
2005-03-04 20:53 ` [PATCH] PCI: Make pci_claim_resource __devinit Greg KH
2005-03-04 20:53 ` [PATCH] PCI: fix pci_remove_legacy_files() crash Greg KH
2005-03-04 20:53 ` [PATCH] PCI: NUMA-Q PCI config access arg validation Greg KH
2005-03-04 20:53 ` [PATCH] PCI: pci_raw_ops should use unsigned args Greg KH
2005-03-04 20:53 ` [PATCH] arch/i386/kernel/pci/irq.c: Wrong message output Greg KH
2005-03-04 20:53 ` [PATCH] PCI: Dynids - passing driver data Greg KH
2005-03-04 20:53 ` [PATCH] drivers/pci/*: convert to pci_register_driver Greg KH
2005-03-04 20:53 ` Greg KH [this message]
2005-03-04 20:53 ` [PATCH] PCI: Add PCI quirk for SMBus on the Toshiba Satellite A40 Greg KH
2005-03-04 20:53 ` [PATCH] PCI: allow x86_64 to do pci express Greg KH
2005-03-04 20:53 ` [PATCH] pci/quirks.c: unhide SMBus device on Samsung P35 laptop Greg KH
2005-03-04 20:53 ` [PATCH] PCI: clean up the msi api Greg KH
2005-03-04 21:00 ` [PATCH] convert pci_dev->slot_name usage to pci_name() Jeff Garzik
2005-03-04 21:07 ` Greg KH
2005-03-04 23:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1109969637954@kroah.com \
--to=greg@kroah.com \
--cc=dlsy@snoqualmie.dp.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.