From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] ppc64-implement-a-vdso-and-use-it-for-signal-trampoline gas workaround
Date: Sun, 06 Mar 2005 09:49:27 +1100 [thread overview]
Message-ID: <1110062967.13607.82.camel@gaston> (raw)
In-Reply-To: <200503051830.j25IU4Vq007528@hera.kernel.org>
On Sat, 2005-03-05 at 17:33 +0000, Linux Kernel Mailing List wrote:
> ChangeSet 1.2212, 2005/03/05 09:33:46-08:00, akpm@osdl.org
>
> [PATCH] ppc64-implement-a-vdso-and-use-it-for-signal-trampoline gas workaround
>
> I cannot find a version of binutils which doesn't either do
>
> arch/ppc64/kernel/vdso32/gettimeofday.S: Assembler messages:
> arch/ppc64/kernel/vdso32/gettimeofday.S:33: Error: syntax error; found `@' but expected `,'
Ugh... Do that still happen once you finally get it to build with a 32
bits compiler and not a 64 bits one ? The @local is actually needed for
the 32 bits build.
> or
>
> arch/ppc64/kernel/vdso32/gettimeofday.S: Assembler messages:
> arch/ppc64/kernel/vdso32/gettimeofday.S:33: Internal error, aborting at ../../gas/config/tc-ppc.c line 2658 in md_assemble
>
>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
>
>
>
> datapage.S | 2 +-
> gettimeofday.S | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
>
> diff -Nru a/arch/ppc64/kernel/vdso32/datapage.S b/arch/ppc64/kernel/vdso32/datapage.S
> --- a/arch/ppc64/kernel/vdso32/datapage.S 2005-03-05 10:30:16 -08:00
> +++ b/arch/ppc64/kernel/vdso32/datapage.S 2005-03-05 10:30:16 -08:00
> @@ -56,7 +56,7 @@
> .cfi_register lr,r12
>
> mr r4,r3
> - bl __get_datapage@local
> + bl __get_datapage
> mtlr r12
> addi r3,r3,CFG_SYSCALL_MAP32
> cmpli cr0,r4,0
> diff -Nru a/arch/ppc64/kernel/vdso32/gettimeofday.S b/arch/ppc64/kernel/vdso32/gettimeofday.S
> --- a/arch/ppc64/kernel/vdso32/gettimeofday.S 2005-03-05 10:30:16 -08:00
> +++ b/arch/ppc64/kernel/vdso32/gettimeofday.S 2005-03-05 10:30:16 -08:00
> @@ -30,9 +30,9 @@
>
> mr r10,r3 /* r10 saves tv */
> mr r11,r4 /* r11 saves tz */
> - bl __get_datapage@local /* get data page */
> + bl __get_datapage /* get data page */
> mr r9, r3 /* datapage ptr in r9 */
> - bl __do_get_xsec@local /* get xsec from tb & kernel */
> + bl __do_get_xsec /* get xsec from tb & kernel */
> bne- 2f /* out of line -> do syscall */
>
> /* seconds are xsec >> 20 */
> -
> To unsubscribe from this list: send the line "unsubscribe bk-commits-head" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Benjamin Herrenschmidt <benh@kernel.crashing.org>
next parent reply other threads:[~2005-03-05 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200503051830.j25IU4Vq007528@hera.kernel.org>
2005-03-05 22:49 ` Benjamin Herrenschmidt [this message]
2005-03-05 23:30 ` [PATCH] ppc64-implement-a-vdso-and-use-it-for-signal-trampoline gas workaround Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110062967.13607.82.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.