Re: [Bluez-devel] Connection with aphonestaysopenafterclosingRFCOMM channel

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

Hi Victor,

> > Hope that explains....
> 
> it does not explain it, but this is what I expected. Another reference
> counting problem. Maybe introduced at that time I fixed another one of
> these crazy problems. Funny is that this does not result in an oops. The
> easiest way to fix this is, if you send me one of these phones, because
> otherwise it will take quite some time to reproduce it.

try the attached patch. It fixes it for me when I tested this with a
Nokia 6310.

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 436 bytes --]

===== net/bluetooth/rfcomm/core.c 1.49 vs edited =====
--- 1.49/net/bluetooth/rfcomm/core.c	2005-01-23 19:59:56 +01:00
+++ edited/net/bluetooth/rfcomm/core.c	2005-03-09 11:27:46 +01:00
@@ -389,6 +389,8 @@
 		rfcomm_dlc_unlock(d);
 
 		skb_queue_purge(&d->tx_queue);
+		rfcomm_session_put(s);
+
 		rfcomm_dlc_unlink(d);
 	}
 
@@ -597,6 +599,8 @@
 		*err = -ENOMEM;
 		goto failed;
 	}
+
+	rfcomm_session_hold(s);
 
 	s->initiator = 1;