From: Dave Hansen <haveblue@us.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mel Gorman <mel@csn.ul.ie>
Subject: Re: [PATCH] add a clear_pages function to clear pages of higher order
Date: Thu, 10 Mar 2005 13:38:03 -0800 [thread overview]
Message-ID: <1110490683.24355.17.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.58.0503101229420.13911@schroedinger.engr.sgi.com>
On Thu, 2005-03-10 at 12:35 -0800, Christoph Lameter wrote:
> +#ifdef __HAVE_ARCH_CLEAR_PAGES
> + if (!PageHighMem(page)) {
> + clear_pages(page_address(page), order);
> + return;
> + }
> +#endif
> +
> for(i = 0; i < (1 << order); i++)
> clear_highpage(page + i);
> }
...
> --- linux-2.6.11.orig/include/asm-ia64/page.h 2005-03-01 23:37:48.000000000 -0800
> +++ linux-2.6.11/include/asm-ia64/page.h 2005-03-10 10:57:10.000000000 -0800
> @@ -56,8 +56,10 @@
> # ifdef __KERNEL__
> # define STRICT_MM_TYPECHECKS
>
> -extern void clear_page (void *page);
> +extern void clear_pages (void *page, int order);
> extern void copy_page (void *to, void *from);
> +#define clear_page(__page) clear_pages(__page, 0)
> +#define __HAVE_ARCH_CLEAR_PAGES
Although this is a simple instance, could this please be done in a
Kconfig file? If that #define happens inside of other #ifdefs, it can
be quite hard to decipher the special .config incantation to get it set.
On the other hand, if the dependencies are spelled out in a Kconfig
entry...
BTW, I tried applying this to 2.6.11-bk6, and it rejected:
...
patching file include/asm-i386/page.h
Hunk #2 FAILED at 28.
1 out of 2 hunks FAILED -- saving rejects to file
include/asm-i386/page.h.rej
...
There were some more rejects as well. Were there some other patches
applied first?
-- Dave
next prev parent reply other threads:[~2005-03-10 21:42 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-10 20:35 [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-10 21:38 ` Dave Hansen [this message]
2005-03-10 22:46 ` Christoph Lameter
2005-03-11 1:03 ` Christoph Lameter
2005-03-11 8:08 ` Denis Vlasenko
2005-03-17 1:33 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-17 1:33 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-18 9:54 ` Denis Vlasenko
2005-03-18 9:54 ` Denis Vlasenko
2005-03-18 15:00 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-18 15:00 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-18 19:28 ` Andi Kleen
2005-03-18 19:28 ` Andi Kleen
2005-03-18 20:19 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-18 20:19 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-20 0:20 ` Denis Vlasenko
2005-03-21 15:30 ` Denis Vlasenko
2005-03-24 18:34 ` David Mosberger
2005-03-24 18:34 ` David Mosberger
2005-03-24 18:41 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-24 18:41 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-24 19:03 ` [PATCH] add a clear_pages function to clear pages of higher David S. Miller
2005-03-24 19:03 ` [PATCH] add a clear_pages function to clear pages of higher order David S. Miller
2005-03-24 22:49 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-24 22:49 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-24 23:13 ` [PATCH] add a clear_pages function to clear pages of higher David S. Miller
2005-03-24 23:13 ` [PATCH] add a clear_pages function to clear pages of higher order David S. Miller
2005-03-25 2:29 ` [PATCH] add a clear_pages function to clear pages of higher David S. Miller
2005-03-25 2:29 ` [PATCH] add a clear_pages function to clear pages of higher order David S. Miller
2005-03-25 2:43 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-25 2:43 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-03-27 17:12 ` Andi Kleen
2005-03-27 17:12 ` Andi Kleen
2005-03-27 18:23 ` [PATCH] add a clear_pages function to clear pages of higher David S. Miller
2005-03-27 18:23 ` [PATCH] add a clear_pages function to clear pages of higher order David S. Miller
2005-03-29 1:58 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-03-29 1:58 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-04-06 0:15 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-04-06 0:15 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-04-06 0:23 ` [PATCH] add a clear_pages function to clear pages of higher David Mosberger
2005-04-06 0:23 ` [PATCH] add a clear_pages function to clear pages of higher order David Mosberger
2005-04-06 0:33 ` [PATCH] add a clear_pages function to clear pages of higher Christoph Lameter
2005-04-06 0:33 ` [PATCH] add a clear_pages function to clear pages of higher order Christoph Lameter
2005-04-06 4:48 ` [PATCH] add a clear_pages function to clear pages of higher David Mosberger
2005-04-06 4:48 ` [PATCH] add a clear_pages function to clear pages of higher order David Mosberger
2005-04-06 5:15 ` Gerrit Huizenga
2005-04-06 5:15 ` Gerrit Huizenga
2005-04-06 16:03 ` Grant Grundler
2005-04-06 16:03 ` Grant Grundler
2005-03-18 10:12 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110490683.24355.17.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.