Re: Re: uhci-hcd suspend/resume under the new driver model

[Benjamin Herrenschmidt <benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1209 bytes --]

On Mon, 2005-03-14 at 10:17 -0800, David Brownell wrote:
> On Monday 14 March 2005 12:08 am, Pavel Machek wrote:
> > 	 I'll really need to make pci_choose_state
> > "NOP" in the current code, so that it can be safely added to the
> > existing drivers.
> 
> There's no point in adding NOPs.  Why bother?
> 
> Remember, the original idea behind pci_choose_state() was that
> PCI drivers for PM-aware devices could use that instead of their
> own dumb mappings between system suspend states (S0, S1, S2, S3,
> S4, etc) and PCI states ... which in too many cases was just to
> re-use the same numeric value.  That's _never_ going to be a NOP,
> unless Linux only ever supports PCI D3hot (ACPI D2) and S3; and
> likewise will never be needed for PM-stupid devices, or for those
> drivers with actual intelligence (e.g. Ben's video examples).

Note that the apple OHCI cell in Apple ASICs, despite beeing a PCI
device, doesn't always expose PCI PM capabilities. We still need to do
the proper suspend stuff on it. So be careful with pci_choose_state().

> My original question is unanswered though:  what tree is it that
> made these (broken) changes to USB?  It's not BK-current, and it's
> not the USB tree...




[-- Attachment #2: Type: text/plain, Size: 0 bytes --]