From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: Fix udev_volume_id for reiserfs v3.5
Date: Tue, 15 Mar 2005 15:49:00 +0000 [thread overview]
Message-ID: <1110901740.6630.83.camel@localhost.localdomain> (raw)
In-Reply-To: <4236E0AA.8000605@suse.de>
On Tue, 2005-03-15 at 16:17 +0100, Hannes Reinecke wrote:
> Kay Sievers wrote:
> > On Tue, 2005-03-15 at 14:18 +0100, Hannes Reinecke wrote:
> >>the attached patch fixes udev_volume_id for old reiserfs volumes.
> >
> > The signature for that version can be at the offset of the later
> > versions? We already check for that signature at a different offset.
> >
> Appearently so.
>
> >>How are we supposed to handle old/invalid labels?
> >>The one I'm reading here is
> >>eb 4d 72 17 06 4e 72 17 09 4e 72 17 53 4e 72 17
> >>which is clearly bogus. I'll check with our fs-gurus but I think
> >>we should filter them out in udev_volume_id.
> >>Can't we test for isascii(rs->label[0]) ?
> >
> > If that helps, sure. But what if the garbage starts at the second char?
> > And what's with the UTF8 char sequences?
> >
> Well, I just asked our resident reiserfs guru (thx mason :-).
> Reiser v3.5 does not support labels nor uuids.
> Corrected patch attached.
Nice! Applied, thanks.
Kay
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_ide95&alloc_id\x14396&op=click
_______________________________________________
Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel
prev parent reply other threads:[~2005-03-15 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-15 13:18 Fix udev_volume_id for reiserfs v3.5 Hannes Reinecke
2005-03-15 14:55 ` Kay Sievers
2005-03-15 15:17 ` Hannes Reinecke
2005-03-15 15:49 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1110901740.6630.83.camel@localhost.localdomain \
--to=kay.sievers@vrfy.org \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.