Re: udev 055

[Kay Sievers <kay.sievers@vrfy.org>]

[-- Attachment #1: Type: text/plain, Size: 986 bytes --]

On Thu, 2005-03-17 at 16:35 -0800, Jim Gifford wrote:
> Kay Sievers wrote:
> 
> >Please run:
> >  udevtest /sys/class/sound/timer sound
> >
> >or whatever is the devpath for that device and look if the right rule
> >gets applied.

> version 054
> looking at '/class/sound/timer'
> opened class_dev->name='timer'
> configured rule in '/etc/udev/rules.d/25-lfs.rules[16]' applied, 'timer' 
> becomes 'snd/%k'
> creating device node '/dev/snd/timer', major = '116', minor = '33', mode 
> = '0660', uid = '0', gid = '17'
> 
> version 055
> looking at '/class/sound/timer'
> opened class_dev->name='timer'
> configured rule in '/etc/udev/rules.d/25-lfs.rules[16]' applied, 'timer' 
> becomes 'snd/%k'
> creating device node '/dev/snd/timer', major = '116', minor = '33', mode 
> = '0660', uid = '0', gid = '0'

I can confirm this. It's a bad typo caused by changing the way klibc is
integrated. We look in /etc/passwd for the group. :(
Patch attached, thanks for catching this.

Thanks,
Kay

[-- Attachment #2: fix-group.patch --]
[-- Type: text/x-patch, Size: 778 bytes --]

===== udev_add.c 1.103 vs edited =====
--- 1.103/udev_add.c	2005-03-12 14:36:31 +01:00
+++ edited/udev_add.c	2005-03-18 01:51:23 +01:00
@@ -150,7 +150,7 @@ static int create_node(struct udevice *u
 		if (endptr[0] == '\0')
 			gid = (gid_t) id;
 		else
-			gid = lookup_user(udev->group);
+			gid = lookup_group(udev->group);
 	}
 
 	if (!udev->test_run) {
===== udev_libc_wrapper.c 1.20 vs edited =====
--- 1.20/udev_libc_wrapper.c	2005-03-18 01:27:30 +01:00
+++ edited/udev_libc_wrapper.c	2005-03-18 01:47:22 +01:00
@@ -140,7 +140,7 @@ static unsigned long get_id_by_name(cons
 		dbg("can't open '%s' as db file", dbfile);
 		return 0;
 	}
-	dbg("reading '%s' as db file", dbfile);
+	dbg("search '%s' in '%s'", uname, dbfile);
 
 	/* loop through the whole file */
 	cur = 0;