From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: sjralston1@netscape.net
Cc: mpt_linux_developer@lsil.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] fix fusion breakage with multiple PCI domains
Date: Fri, 18 Mar 2005 10:25:18 -0700 [thread overview]
Message-ID: <1111166718.13286.23.camel@eeyore> (raw)
In-Reply-To: <1111089617.11380.40.camel@eeyore>
On Thu, 2005-03-17 at 13:00 -0700, Bjorn Helgaas wrote:
> mpt_detect_bound_ports(): Don't assume that two devices with the same
> dev->bus->number are on the same bus. With multiple PCI domains,
> many buses may have the same number.
Maybe mpt_detect_bound_ports() could be rewritten to use pci_get_slot()
instead? tg3_find_5704_peer() looks like it's doing basically the
same thing; maybe you could copy it.
> ===== drivers/message/fusion/mptbase.c 1.40 vs edited =====
> --- 1.40/drivers/message/fusion/mptbase.c 2005-03-13 16:30:09 -07:00
> +++ edited/drivers/message/fusion/mptbase.c 2005-03-17 12:46:57 -07:00
> @@ -1834,14 +1834,14 @@
>
> match_lo = pdev->devfn-1;
> match_hi = pdev->devfn+1;
> - dprintk((MYIOC_s_INFO_FMT "PCI bus/devfn=%x/%x, searching for devfn match on %x or %x\n",
> - ioc->name, pdev->bus->number, pdev->devfn, match_lo, match_hi));
> + dprintk((MYIOC_s_INFO_FMT "PCI device %s devfn=%x/%x, searching for devfn match on %x or %x\n",
> + ioc->name, pci_name(pdev), pdev->devfn, match_lo, match_hi));
>
> list_for_each_entry(ioc_srch, &ioc_list, list) {
> struct pci_dev *_pcidev = ioc_srch->pcidev;
>
> if ((_pcidev->device == pdev->device) &&
> - (_pcidev->bus->number == pdev->bus->number) &&
> + (_pcidev->bus == pdev->bus) &&
> (_pcidev->devfn == match_lo || _pcidev->devfn == match_hi) ) {
> /* Paranoia checks */
> if (ioc->alt_ioc != NULL) {
>
next prev parent reply other threads:[~2005-03-18 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-17 20:00 [PATCH] fix fusion breakage with multiple PCI domains Bjorn Helgaas
2005-03-18 17:25 ` Bjorn Helgaas [this message]
2005-03-25 16:25 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1111166718.13286.23.camel@eeyore \
--to=bjorn.helgaas@hp.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mpt_linux_developer@lsil.com \
--cc=sjralston1@netscape.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.