From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerone Young Subject: Re: [PATCH] tools top level makefile cleanup Date: Tue, 22 Mar 2005 15:46:34 -0600 Message-ID: <1111527994.3796.16.camel@thinkpad> References: <1111525821.3796.4.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit In-Reply-To: Sender: xen-devel-admin@lists.sourceforge.net Errors-To: xen-devel-admin@lists.sourceforge.net List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , List-Archive: To: Adam Heath Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On Tue, 2005-03-22 at 15:33 -0600, Adam Heath wrote: > On Tue, 22 Mar 2005, Jerone Young wrote: > > > I cleaned up the top level makefile in the tools directory. No major > > changes. Except I have it so that ioemmu is compiled only with x86_32. > > > > Signed-off-by: Jerone Young > > > > +all: > > + @for subdir in $(SUBDIRS); do \ > > + $(MAKE) -C $$subdir $@ || exit -1; \ > > + done > > + > > +clean: > > + @for subdir in $(SUBDIRS); do \ > > + $(MAKE) -C $$subdir $@ || exit -1; \ > > + done > > + > > +install: > > + @for subdir in $(SUBDIRS); do \ > > + $(MAKE) -C $$subdir $@ || exit -1; \ > > + done > > Don't do it like this. make -j won't work. Hmm...I mainly did this to clean up things for development purposes. I don't know if everyone cares all that much about the using the -j option with building the tools (maybe..someone speakup!). It really does not take anytime now to build them without it. Also you have to build libxutil & libxc first so your not going to get a huge performance increase because everything is dependent on these getting built first. > > Besides, don't use || exit. Instead, use set -e. We want the build to die (with extreme prejudice :-) ) if something does not go right. > -- Jerone Young IBM Linux Technology Center jyoung5@us.ibm.com 512-838-1157 (T/L: 678-1157) ------------------------------------------------------- This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click