Re: [PATCH][RESUBMIT] tools top level makefile cleanup

[Jerone Young <jyoung5@us.ibm.com>]

That can easily be fixed when put in the tree. The main point is to exit
with a non zero value. True by exiting with -1 can't get the negative
exit code from the shell (you would get 255). But still bahaviors the
same way if $? != 0 then we know something is wrong.

On Fri, 2005-03-25 at 14:21 -0600, Adam Heath wrote:
> On Fri, 25 Mar 2005, Adam Heath wrote:
> 
> > On Fri, 25 Mar 2005, Jerone Young wrote:
> >
> > > +all: check
> > > + @for subdir in $(SUBDIRS); do \
> > > + $(MAKE) -C $$subdir $@ || exit -1; \
> > > + done
> >
> > How is this a valid makefile?  Where's the tab?
> 
> Please use "@set -e; for ...", and remove the "|| exit -1".
> 
> Besides, exit -1 is poor, it s/b a positive number.  It's not really possible
> to exit with a negative value.
> 
-- 
Jerone Young
IBM Linux Technology Center
jyoung5@us.ibm.com
512-838-1157 (T/L: 678-1157)



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click