From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andreas Schwab <schwab@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] radeonfb: (#2) Implement proper workarounds for PLL accesses
Date: Thu, 07 Apr 2005 08:47:35 +1000 [thread overview]
Message-ID: <1112827655.9518.194.camel@gaston> (raw)
In-Reply-To: <jeoecr1qk8.fsf@sykes.suse.de>
On Thu, 2005-04-07 at 00:35 +0200, Andreas Schwab wrote:
> Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
>
> > Hrm... it should only add a few ms, maybe about 20 ms to the mode
> > switching... If you remove the radeon_msleep(5) call from the
> > radeon_pll_errata_after_data() routine in radeonfb.h, does it make a
> > difference ?
>
> Yes, it does. Without the sleep, switching is as fast as before.
It is weird tho. Could you try adding a printk or something to figure
out how much this is called during a typical swich ? It will seriously
spam your console though ... I would expect only 5 or 6 calls during a
normal switch (since the PLL value shouldn't change for a flat panel),
that is no more than maybe 50ms, while it seems you are having a much
bigger delay.
Ben.
next prev parent reply other threads:[~2005-04-06 22:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-11 5:42 [PATCH] radeonfb: Implement proper workarounds for PLL accesses Benjamin Herrenschmidt
2005-03-13 0:12 ` [PATCH] radeonfb: (#2) " Benjamin Herrenschmidt
2005-04-05 21:44 ` Andreas Schwab
2005-04-05 23:31 ` Benjamin Herrenschmidt
2005-04-06 22:35 ` Andreas Schwab
2005-04-06 22:47 ` Benjamin Herrenschmidt [this message]
2005-04-07 20:21 ` Andreas Schwab
2005-04-07 21:22 ` Dave Airlie
2005-04-07 22:59 ` Benjamin Herrenschmidt
2005-04-07 23:58 ` Andreas Schwab
2005-04-08 0:03 ` Benjamin Herrenschmidt
2005-04-08 1:19 ` Benjamin Herrenschmidt
2005-04-08 1:19 ` Benjamin Herrenschmidt
2005-04-08 21:11 ` Andreas Schwab
2005-04-09 0:03 ` Benjamin Herrenschmidt
2005-04-09 0:03 ` Benjamin Herrenschmidt
2005-04-09 16:24 ` Andreas Schwab
2005-04-09 23:33 ` Benjamin Herrenschmidt
2005-04-09 23:33 ` Benjamin Herrenschmidt
2005-04-10 10:05 ` Moritz Muehlenhoff
2005-04-10 22:45 ` Benjamin Herrenschmidt
2005-04-10 23:10 ` Brice Goglin
2005-04-07 22:47 ` Benjamin Herrenschmidt
2005-04-07 23:13 ` Andreas Schwab
2005-04-07 23:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1112827655.9518.194.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.