Re: [Bluez-devel] [PATCH] RFCOMM does not call tty_hangup() when DCD is de-asserted

[Marcel Holtmann <marcel@holtmann.org>]

Hi Timo,

> It seems that RFCOMM does not handle properly the de-assertation of CD 
> signal. It should call tty_hangup() to work properly.
> 
> One side effect is that data calls that are hanged up from remote side 
> are not detected as being hanged up.
> 
> I've made a very quick patch for this. In my case this patch enabled the 
> detection carried detect signal de-assertation. But since I'm not an 
> expert on RFCOMM stuff there might be some cases where tty_hangup() 
> should not be called. In serial side the DCD change is handled by 
> uart_handle_dcd_change() defined in include/linux/serial_core.h and it 
> has some extra checks there as well.
> 
> So could some one wiser there check what actually has to be done for the 
> hangup mechanism to work properly. Or if my patch looks good enough feel 
> free to commit it.

from my part this patch looks fine, but I don't like the modem emulation
part of RFCOMM in general. For me it is only a stream. Nothing less and
nothing more. So if this patch is useful I am going to apply it.
 
> +	if ((dev->modem_status & TIOCM_CD) &&
> +	    !(v24_sig & RFCOMM_V24_DV)) {

You must comply with the coding style here. So change it into

	if ((dev->modem_status & TIOCM_CD) && !(v24_sig & RFCOMM_V24_DV)) {

And don't forget to add a Signed-off-by: line when you resend it.

Regards

Marcel




-------------------------------------------------------
This SF.Net email is sponsored by: New Crystal Reports XI.
Version 11 adds new functionality designed to reduce time involved in
creating, integrating, and deploying reporting solutions. Free runtime info,
new features, or free trial, at: http://www.businessobjects.com/devxi/728
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel