From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Colin Leroy <colin@colino.net>
Cc: Takashi Iwai <tiwai@suse.de>,
linuxppc-dev list <linuxppc-dev@ozlabs.org>,
"debian-powerpc@lists.debian.org"
<debian-powerpc@lists.debian.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.12-rc3] pmac: save master volume on sleep
Date: Fri, 22 Apr 2005 10:17:14 +1000 [thread overview]
Message-ID: <1114129034.18680.34.camel@gaston> (raw)
In-Reply-To: <20050421200408.5361a5b3@jack.colino.net>
On Thu, 2005-04-21 at 20:04 +0200, Colin Leroy wrote:
> Hi,
>
> Ben's patch that shutdowns master switch and restores it after
> resume ("pmac: Improve sleep code of tumbler driver") isn't enough here
> on an iBook (snapper chip).
>
> The master switch is correctly saved and restored, but somehow
> tumbler_put_master_volume() gets called just after
> tumbler_set_master_volume() and sets mix->master_vol[*] to 0. So, on
> resuming, the master switch is reenabled, but the volume is set to 0.
>
> Here's a patch that also saves and restores master_vol.
> Thanks,
Looks good.
Ben.
next prev parent reply other threads:[~2005-04-22 0:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-21 18:04 [PATCH 2.6.12-rc3] pmac: save master volume on sleep Colin Leroy
2005-04-22 0:17 ` Benjamin Herrenschmidt [this message]
2005-04-24 16:24 ` Colin Leroy
2005-04-24 16:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1114129034.18680.34.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=colin@colino.net \
--cc=debian-powerpc@lists.debian.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.