Re: [PATCH][RFC] Linux VM hooks for advanced RDMA NICs

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Tue, 2005-04-26 at 13:13 -0400, Lee Revell wrote:
> On Tue, 2005-04-26 at 18:57 +0200, Jesper Juhl wrote:
> > > 
> > > +static inline void
> > > +ioproc_release(struct mm_struct *mm)
> > > +{
> > 
> > Return types on same line as function name makes grep'ing a lot 
> > easier/nicer.
> > 
> > Here's the example from Documentation/CodingStyle : 
> > 
> >         int function(int x)
> >         {
> 
> How so?  I never understood the reasons.  This makes it easier to grep
> for everything that returns int.  But you make the common case (what
> file is function() defined in?) harder.

Not exactly. I used the 2-lines style for a while, and changed overtime
and now can't stand anything but the one line style  :)

I recommend you read the mailing list archives for linus comments on
this issue btw.

Ben.