From: Arjan van de Ven <arjan@infradead.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: YOSHIFUJI Hideaki / ???? <yoshfuji@linux-ipv6.org>,
michaelc@cs.wisc.edu, linux-scsi@vger.kernel.org,
netdev@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class
Date: Thu, 05 May 2005 07:45:47 -0400 [thread overview]
Message-ID: <1115293547.6052.1.camel@localhost.localdomain> (raw)
In-Reply-To: <E1DTehn-0005gJ-00@gondolin.me.apana.org.au>
On Thu, 2005-05-05 at 21:39 +1000, Herbert Xu wrote:
> YOSHIFUJI Hideaki / ???? <yoshfuji@linux-ipv6.org> wrote:
> > In article <42798AC1.2010308@cs.wisc.edu> (at Wed, 04 May 2005 19:53:53 -0700), Mike Christie <michaelc@cs.wisc.edu> says:
> >
> >> +struct iscsi_uevent {
> > :
> >> +} __attribute__ ((aligned (sizeof(unsigned long))));
> >
> > I think it'd be better to use sizeof(uint64_t) or something.
>
> Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?
why align at all as opposed to just letting the compiler figure it out.
next prev parent reply other threads:[~2005-05-05 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-05 2:53 [PATCH 2/3] add open iscsi netlink interface to iscsi transport class Mike Christie
2005-05-05 9:55 ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-05 11:39 ` Herbert Xu
2005-05-05 11:39 ` Herbert Xu
2005-05-05 11:45 ` Arjan van de Ven [this message]
2005-05-05 11:55 ` YOSHIFUJI Hideaki / 吉藤英明
2005-05-05 12:22 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2005-05-15 19:30 Mike Christie
2005-05-15 19:30 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115293547.6052.1.camel@localhost.localdomain \
--to=arjan@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.