From: Robert Love <rml@novell.com>
To: Vladimir Saveliev <vs@namesys.com>
Cc: Andrew Morton <akpm@osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"reiserfs-dev@namesys.com" <reiserfs-dev@namesys.com>
Subject: Re: [PATCH] sync_sb_inodes cleanup
Date: Tue, 10 May 2005 11:35:01 -0400 [thread overview]
Message-ID: <1115739301.6810.15.camel@betsy> (raw)
In-Reply-To: <1115737238.4456.320.camel@tribesman.namesys.com>
On Tue, 2005-05-10 at 19:00 +0400, Vladimir Saveliev wrote:
> This patch makes generic_sync_sb_inodes to spin lock itself.
> Please, apply this patch. It helps reiser4 to get rid of some oddities.
>
> [snip]
>
> {
> const unsigned long start = jiffies; /* livelock avoidance */
>
> + spin_lock(&inode_lock);
Looking at what jiffies is used for, it is probably is not a big deal,
but you should move the assignment of start to after acquiring the lock,
as that could take quite some time.
Robert Love
next prev parent reply other threads:[~2005-05-10 15:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 15:00 [PATCH] sync_sb_inodes cleanup Vladimir Saveliev
2005-05-10 15:35 ` Robert Love [this message]
2005-05-11 7:37 ` Vladimir Saveliev
2005-05-11 17:49 ` Robert Love
2005-05-13 9:25 ` Vladimir Saveliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115739301.6810.15.camel@betsy \
--to=rml@novell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-dev@namesys.com \
--cc=vs@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.