From: Thomas Gleixner <tglx@linutronix.de>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Stop git-rev-list at sha1 match
Date: Wed, 11 May 2005 20:30:29 +0000 [thread overview]
Message-ID: <1115843429.22180.90.camel@tglx> (raw)
In-Reply-To: <7vy8alr0mz.fsf@assigned-by-dhcp.cox.net>
On Wed, 2005-05-11 at 13:03 -0700, Junio C Hamano wrote:
> Suggestion. How about renaming "--to_sha1" to "--since"? If
> you do not like "--since", then "--stop-at" would also be good.
No preference here :)
> Suggestion. Instead of running sha1_to_hex on the SHA1 of the
> commit and comparing strings for every commit you encounter, how
> about keeping 20-byte raw SHA1 of to_sha1 and doing memcmp of
> 20-byte? That way you would also detect malformed --to-sha1
> parameter when you do the initial conversion upon argument
> parsing. Also the argument parsing using get_sha1() would give
> you an added benefit of using mnemonics (tag and heads).
Makes sense. I just used the sha1_to_hex as it is called anyway for the
printf
> What do you think about this revision?
You moved the stop behind the printf which is inconsistent to the other
stop conditions, but thats a pure cosmetic question as long as it stays
that way for ever.
Otherwise not objections.
tglx
next prev parent reply other threads:[~2005-05-11 20:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 19:24 [PATCH] Stop git-rev-list at sha1 match Thomas Gleixner
2005-05-11 20:03 ` Junio C Hamano
2005-05-11 20:30 ` Thomas Gleixner [this message]
2005-05-11 21:54 ` Junio C Hamano
2005-05-11 22:17 ` Petr Baudis
2005-05-11 22:49 ` Thomas Gleixner
2005-05-11 22:50 ` Petr Baudis
2005-05-11 23:08 ` Thomas Gleixner
2005-05-11 23:44 ` Petr Baudis
2005-05-12 0:31 ` Thomas Gleixner
2005-05-13 5:26 ` Petr Baudis
2005-05-12 1:54 ` Junio C Hamano
2005-05-12 2:11 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115843429.22180.90.camel@tglx \
--to=tglx@linutronix.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.