Re: [Qemu-devel] [Patch] target-ppc mtcrf instruction not recognized

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

> OK, I did put this in my working repository and I'll submit this to
> Fabrice.
> Please try to do this change to check if other bits need to be relax or
> not:
> 
> Index: target-ppc/translate.c
> ===================================================================
> RCS file: /cvsroot/qemu/qemu/target-ppc/translate.c,v
> retrieving revision 1.31
> diff -u -r1.31 translate.c
> --- target-ppc/translate.c      12 May 2005 18:46:11 -0000      1.31
> +++ target-ppc/translate.c      14 May 2005 17:14:35 -0000
> @@ -2123,7 +2123,7 @@
>  }
>  
>  /* mtcrf */
> -GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00100801, PPC_MISC)
> +GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00000801, PPC_MISC)
>  {
>      gen_op_load_gpr_T0(rS(ctx->opcode));
>      gen_op_store_cr(CRM(ctx->opcode));
> 
> And maybe someone should fill an Apple bug report to tell them their as
> is buggy ;-)

It is definitely a bug in Apple assembler I would say, so I suggest you
add a comment in the above patch in order to avoid somebody later on
"fixing" your mask :)

Ben.